Remove TransactionTableModel::TxIDRole #12620

pull promag wants to merge 1 commits into bitcoin:master from promag:2018-03-remove-txidrole changing 8 files +8 −12

promag commented at 8:27 PM on March 6, 2018: member

The role TxIDRole is a duplicate of TxHashRole. This change favours TxHashRole.
fanquake added the label Refactoring on Mar 6, 2018
laanwj commented at 8:47 PM on March 6, 2018: member

utACK - I think it was duplicated because TxID used to contain the vout id at some point, too.
laanwj added the label GUI on Mar 6, 2018
practicalswift commented at 10:03 PM on March 6, 2018: contributor

Concept ACK
jonasschnelli commented at 2:31 AM on March 7, 2018: contributor

utACK b73cd923c451d926e475482ed7dcdac47444cdb2
MarcoFalke commented at 3:53 AM on March 7, 2018: member

utACK b73cd923c451d926e475482ed7dcdac47444cdb2

jonasschnelli commented at 10:48 AM on March 7, 2018: contributor

See travis report:

qt/transactionfilterproxy.cpp: In member function ‘virtual bool TransactionFilterProxy::filterAcceptsRow(int, const QModelIndex&) const’:
qt/transactionfilterproxy.cpp:39:31: error: ‘TxIDRole’ is not a member of ‘TransactionTableModel’
     QString txid = index.data(TransactionTableModel::TxIDRole).toString();

qt: Remove TransactionTableModel::TxIDRole 3b26b6af72
promag force-pushed on Mar 7, 2018
promag commented at 1:08 PM on March 7, 2018: member

Somehow missed that. Fixed.
MarcoFalke commented at 1:12 PM on March 7, 2018: member

re-utACK 3b26b6af728d5ac538d333a1275073c7c5a012e1
laanwj merged this on Mar 7, 2018
laanwj closed this on Mar 7, 2018
laanwj referenced this in commit 8a43bdcffd on Mar 7, 2018
PastaPastaPasta referenced this in commit 327edd47c9 on Jun 13, 2020
PastaPastaPasta referenced this in commit 8d35bab1da on Jun 13, 2020
PastaPastaPasta referenced this in commit 88552825cf on Jun 17, 2020
PastaPastaPasta referenced this in commit 5e5a0fbd7e on Jun 18, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels