bitcoin-cli: Provide a better error message when bitcoind is not running #12652

pull practicalswift wants to merge 3 commits into bitcoin:master from practicalswift:bitcoin-cli-error-message-when-bitcoind-is-not-running changing 2 files +25 −11

practicalswift commented at 5:41 AM on March 9, 2018: contributor

Provide a better bitcoin-cli error message when bitcoind is not running.

Before this patch:

$ killall -9 bitcoind
$ bitcoin-cli -testnet echo 'hello world'
error: Could not locate RPC credentials. No authentication cookie could be found, and RPC password is not set.  See -rpcpassword and -stdinrpcpass.  Configuration file: (/root/.bitcoin/bitcoin.conf)

After this patch:

$ killall -9 bitcoind
$ bitcoin-cli -testnet echo 'hello world'
error: Could not connect to the server 127.0.0.1:18332

Make sure the bitcoind server is running and that you are connecting to the correct RPC port.

practicalswift force-pushed on Mar 9, 2018
practicalswift force-pushed on Mar 9, 2018
practicalswift force-pushed on Mar 9, 2018
practicalswift force-pushed on Mar 9, 2018
randolf approved
jonasschnelli commented at 6:33 AM on March 9, 2018: contributor

I guess you need to fix the interface_bitcoin_cli.py test.
meshcollider added the label Utils/log/libs on Mar 9, 2018

bitcoin-cli: Provide a better error message when bitcoind is not running

Before this patch:

```
$ bitcoin-cli -testnet echo 'hello world'
error: Could not locate RPC credentials. No authentication cookie could be found, and RPC password is not set.  See -rpcpassword and -stdinrpcpass.  Configuration file: (/root/.bitcoin/bitcoin.conf)
```

After this patch:

```
$ bitcoin-cli -testnet echo 'hello world'
error: Could not connect to the server 127.0.0.1:18332

Make sure the bitcoind server is running and that you are connecting to the correct RPC port.
```

de04fde534

practicalswift force-pushed on Mar 9, 2018
practicalswift commented at 2:54 PM on March 9, 2018: contributor

@jonasschnelli Oh, thanks! Fixed. Please re-review :-)
instagibbs commented at 5:40 PM on March 9, 2018: member

utACK https://github.com/bitcoin/bitcoin/pull/12652/commits/de04fde534997f15235ded46912806d47c615c23
cdecker commented at 5:54 PM on March 9, 2018: contributor

utACK de04fde
laanwj commented at 12:31 PM on March 10, 2018: member

Concept ACK.

However I remember making the code like this to avoid certain edge cases around the authentication credentials and connectability.

Can we please add tests for this? This logic was already complicated, and this makes it even more complicated.

in src/bitcoin-cli.cpp:368 in de04fde534 outdated

 368 | +        }
 369 | +        throw CConnectionFailed(strprintf("Could not connect to the server %s:%d%s\n\nMake sure the bitcoind server is running and that you are connecting to the correct RPC port.", host, port, responseErrorMessage));
 370 | +    } else if (response.status == HTTP_UNAUTHORIZED) {
 371 | +        if (failedToGetAuthCookie) {
 372 | +            throw std::runtime_error(strprintf(
 373 | +                _("Could not locate RPC credentials. No authentication cookie could be found, and RPC password is not set.  See -rpcpassword and -stdinrpcpass.  Configuration file: (%s)"),

MarcoFalke commented at 9:52 PM on March 11, 2018:

Mind to add a test for this?

practicalswift commented at 9:46 PM on March 19, 2018:

Added :-)

in src/bitcoin-cli.cpp:364 in de04fde534 outdated

 364 | +    if (response.status == 0) {
 365 | +        std::string responseErrorMessage;
 366 | +        if (response.error != -1) {
 367 | +            responseErrorMessage = strprintf(" (error code %d - \"%s\")", response.error, http_errorstring(response.error));
 368 | +        }
 369 | +        throw CConnectionFailed(strprintf("Could not connect to the server %s:%d%s\n\nMake sure the bitcoind server is running and that you are connecting to the correct RPC port.", host, port, responseErrorMessage));

MarcoFalke commented at 9:53 PM on March 11, 2018:

Same here. Should come with a test.

practicalswift commented at 9:46 PM on March 19, 2018:

Added :-)

practicalswift commented at 9:43 PM on March 19, 2018: contributor

Tests added. Please re-review :-)
tests: Test connecting to a non-existing server a2b2476e96
tests: Test connecting with non-existing RPC cookie file 8b2ef27ff9
practicalswift force-pushed on Mar 19, 2018
laanwj commented at 9:42 AM on March 20, 2018: member

utACK 8b2ef27ff9be20fc1a53d8804b403859251f1fca / tests look good to me, thanks for adding them.
laanwj merged this on Mar 20, 2018
laanwj closed this on Mar 20, 2018
laanwj referenced this in commit 55f490a79f on Mar 20, 2018
markblundeberg referenced this in commit 360670aa78 on Jun 21, 2019
jtoomim referenced this in commit 74bdb54fe7 on Jun 29, 2019
PastaPastaPasta referenced this in commit 04704bea07 on Jun 10, 2020
PastaPastaPasta referenced this in commit e2612ee16d on Jun 13, 2020
PastaPastaPasta referenced this in commit 24a2ebb689 on Jun 13, 2020
PastaPastaPasta referenced this in commit 4f3a0974fc on Jun 13, 2020
PastaPastaPasta referenced this in commit 7007aabb86 on Jun 17, 2020
practicalswift deleted the branch on Apr 10, 2021
gades referenced this in commit 8553bfd920 on Mar 15, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels