Remove unused -testsafemode [AKA: why this PR is wrong] #12687

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2018-03/testsafemode changing 3 files +0 −6
  1. Sjors commented at 5:21 PM on March 14, 2018: member

    Unlike -disablesafemode, all -testsafemode seems to do is display the following message in QT:

    schermafbeelding 2018-03-14 om 13 10 55

    However @achow101 and @practicalswift point out there's more going on:

    -testsafemode is not unused. It is part of GetWarnings and will set a warning for strStatusBar, strRPC, and strGUI which will then trigger the safe mode handling of RPCs. Safe mode is still used in the RPCs to disable certain RPCs if safe mode is enabled.

    Ah, sorry. I missed that the safe mode logic in OnRPCPreCommand is triggered by strRPC != nullptr (via GetWarnings("rpc") :-) Thanks for clarifying. Reverting that part of this PR.

    That's way too indirect / convoluted for my taste. I'll just leave this PR for future reference.

    PS #18 might be closable.

  2. Remove unused -testsafemode 6b92e258f4
  3. Sjors closed this on Mar 14, 2018
  4. MarcoFalke locked this on Sep 8, 2021
Contributors
Sjors
Linked (view graph)
#18 Error when trying to send very precise amount#10560 Remove unused constants
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me