UI console improvements #1269

pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2012_05_consoleimprovements changing 3 files +79 −99
  1. laanwj commented at 10:40 AM on May 12, 2012: member

    Convert RPC console to QTextEdit instead of QTableView

    • This allows copy/pasting whole or partial messages
    • Handle output more consistently in console
      • No more scrollbars-in-scrollbars: by setting per-pixel scrolling on the table, cells can have any height
    • Decorations for "request" and "reply" are changed to the txin and txout icons instead of colored squares
  2. gmaxwell commented at 11:16 AM on May 12, 2012: contributor

    Awesome, it looks great— except copying is kinda broken now, you can only copy the whole row (including the timestamp). E.g. getinfo and then copy the difficulty for me. Other than that I think it's great.

  3. laanwj commented at 11:30 AM on May 12, 2012: member

    I've removed the timestamps from the copy output. Apart from that, there's little to do, Qt only supports copying entire cells at once at most (or you end up back with scrollbars in the cells, if widgets are placed in there).

  4. laanwj commented at 1:19 PM on May 12, 2012: member

    Ok, what about this? The output is now a rich text view instead of a tableview, should be easier for copying.

  5. gmaxwell commented at 2:22 PM on May 12, 2012: contributor

    Looks a little less clean, but its worth it for the big improvement in copy behavior. I think it should be set to a monospace font (will make the hashes and such line up).

  6. Convert RPC console to QTextEdit instead of QTableView
    * This allows copy/pasting whole or partial messages
    * Handle output more consistently in console
        * No more scrollbars-in-scrollbars: by setting per-pixel scrolling on the table, cells can have any height
    * Decorations for "request" and "reply" are changed to the txin and txout icons instead of colored squares
    c6aa86afc2
  7. RPC console: don't crash on invalid input exception ae744c8b78
  8. laanwj commented at 4:44 PM on May 12, 2012: member

    Should be better / good enough now. Explicitly scaling the icons with bilinear filtering so that they don't look ragged, and switched to a monospace font.

  9. sipa commented at 4:50 PM on May 12, 2012: member

    I like.

  10. Diapolo commented at 10:08 PM on May 12, 2012: none

    Could you post a screen after the update :)?

  11. gmaxwell referenced this in commit 85a2229264 on May 12, 2012
  12. gmaxwell merged this on May 12, 2012
  13. gmaxwell closed this on May 12, 2012

  14. coblee referenced this in commit 133d87cec2 on Jul 17, 2012
  15. laanwj deleted the branch on Apr 9, 2014
  16. suprnurd referenced this in commit 5254255a0a on Dec 5, 2017
  17. lateminer referenced this in commit 0771075668 on May 6, 2020
  18. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me