This idea is from discussion in #12686 . GCC 4.8 supports two -fsanitize flags, -fsanitize=address and -fsanitize=thread (and newer versions support even more of these flags). It would be a good idea to enable these options in Travis. @sipa points out that the build still isn't completely clean when using these flags, so to add this we'd either have to fix all of the existing errors or some up with a whilelisting mechanism to grandfather the old violations.
-
eklitzke commented at 2:10 AM on March 15, 2018: contributor
- fanquake added the label Tests on Mar 15, 2018
-
eklitzke commented at 5:31 PM on March 22, 2018: contributor
I'm trying to add a configure option for this in #12692 .
I tested the Bitcoin test suite with various sanitizer configurations, and the Bitcoin test suite passes cleanly with the
threadandundefinedsanitizers, but there are serious issues with theaddresssanitizer that need to be resolved. The address sanitizer injects a segfault when errors occur, so enabling this in Travis is an all-or-nothing kind of thing. -
MarcoFalke commented at 8:22 PM on April 11, 2018: member
Since some of the sanitizers are exclusive, we could enable one of the sanitisers for each of the travis jobs that run the functional test suite?
- MarcoFalke added the label good first issue on Jul 14, 2018
-
MarcoFalke commented at 3:24 PM on August 24, 2018: member
The thread sanitizer fails again after #13247. It could make sense to fix that issue and then set
--with-sanitizers=threadfor thex86_64 Linux, No wallettravis job, which runs the unit tests, but not the functional tests.Same for the undefined sanitizer.
- laanwj referenced this in commit 0ae15bd05f on Aug 27, 2018
-
- MarcoFalke closed this on Mar 7, 2019
- Munkybooty referenced this in commit 0c2de3a954 on Jun 30, 2021
- Munkybooty referenced this in commit d973e50968 on Jun 30, 2021
- Munkybooty referenced this in commit 8fe64f740e on Jul 1, 2021
- Munkybooty referenced this in commit 49e86df289 on Jul 2, 2021
- Munkybooty referenced this in commit 3e72c81f70 on Jul 2, 2021
- Munkybooty referenced this in commit 19fc1dcf01 on Jul 4, 2021
- UdjinM6 referenced this in commit 3de8dd48e8 on Jul 7, 2021
- Munkybooty referenced this in commit 216eb6fb69 on Jul 7, 2021
- UdjinM6 referenced this in commit 5bef8db181 on Jul 7, 2021
- Munkybooty referenced this in commit a24a351158 on Jul 7, 2021
- Munkybooty referenced this in commit 7327a0b2ec on Jul 8, 2021
- DrahtBot locked this on Dec 16, 2021
