Remove unused variable in SortForBlock #12693

1. 
   drewx2 commented at 6:15 am on March 15, 2018: none

   Although txiter is passed to BlockAssembler::SortForBlock, it is never used. Other than BlockAssembler::addPackageTxs, no other method ever makes a call to SortForBlock, thus making this change harmless.
2. Remove unused variable in SortForBlock bb079a0e2c
3. fanquake added the label Refactoring on Mar 15, 2018
4. fanquake added the label Mining on Mar 15, 2018
5. 
   practicalswift commented at 7:26 am on March 15, 2018: contributor

   Nice first-time contribution! Concept ACK!
6. 
   drewx2 commented at 7:30 am on March 15, 2018: none

   Thanks!
7. 
   donaloconnor commented at 10:19 pm on March 15, 2018: contributor

   Concept ACK
8. 
   promag commented at 10:33 pm on March 15, 2018: member

   Obvious ACK bb079a0. Have you checked if it was ever used and if so what PR changed that?
9. 
   sipa commented at 10:33 pm on March 15, 2018: member

   utACK bb079a0e2c20beb22456c91ad9e11beeae7cdc34. @sdaftuar Do you know if there was any reason to pass this variable down for a future purpose?
10. sipa requested review from sdaftuar on Mar 15, 2018
11. 
    sipa commented at 10:43 pm on March 15, 2018: member

    It was unused in c82a4e9a63a, the commit that introduced the code.
12. 
    promag commented at 10:52 pm on March 15, 2018: member

    Right, IMO should be removed now and added again only when needed.
13. 
    practicalswift commented at 10:53 pm on March 15, 2018: contributor

    utACK bb079a0e2c20beb22456c91ad9e11beeae7cdc34
14. sdaftuar approved
15. 
    sdaftuar commented at 11:09 pm on March 15, 2018: member

    utACK. I think this was just an oversight (perhaps leftover from my first implementation which didn’t take advantage of ancestor-count-sorting to do the sort).
16. sipa merged this on Mar 15, 2018
17. sipa closed this on Mar 15, 2018

    ---

18. sipa referenced this in commit df529dcc65 on Mar 15, 2018
19. Mengerian referenced this in commit 2d00337ef7 on Aug 6, 2019
20. PastaPastaPasta referenced this in commit 3ec86fdbeb on Jun 10, 2020
21. PastaPastaPasta referenced this in commit 0144b2b0c0 on Jun 13, 2020
22. PastaPastaPasta referenced this in commit 427e31d8ef on Jun 13, 2020
23. PastaPastaPasta referenced this in commit 4fd7ef0b98 on Jun 13, 2020
24. PastaPastaPasta referenced this in commit c94c99f6fa on Jun 17, 2020
25. MarcoFalke locked this on Sep 8, 2021

Contributors
drewx2 practicalswift donaloconnor promag sipa sdaftuar

Labels
Refactoring Mining