Although txiter is passed to BlockAssembler::SortForBlock, it is never used. Other than BlockAssembler::addPackageTxs, no other method ever makes a call to SortForBlock, thus making this change harmless.
Remove unused variable in SortForBlock #12693
pull drewx2 wants to merge 1 commits into bitcoin:master from drewx2:unused-sort-for-block-param changing 2 files +3 −3-
drewx2 commented at 6:15 AM on March 15, 2018: none
-
Remove unused variable in SortForBlock bb079a0e2c
- fanquake added the label Refactoring on Mar 15, 2018
- fanquake added the label Mining on Mar 15, 2018
-
practicalswift commented at 7:26 AM on March 15, 2018: contributor
Nice first-time contribution! Concept ACK!
-
drewx2 commented at 7:30 AM on March 15, 2018: none
Thanks!
-
donaloconnor commented at 10:19 PM on March 15, 2018: contributor
Concept ACK
-
promag commented at 10:33 PM on March 15, 2018: member
Obvious ACK bb079a0. Have you checked if it was ever used and if so what PR changed that?
-
- sipa requested review from sdaftuar on Mar 15, 2018
-
sipa commented at 10:43 PM on March 15, 2018: member
It was unused in c82a4e9a63a, the commit that introduced the code.
-
promag commented at 10:52 PM on March 15, 2018: member
Right, IMO should be removed now and added again only when needed.
-
practicalswift commented at 10:53 PM on March 15, 2018: contributor
utACK bb079a0e2c20beb22456c91ad9e11beeae7cdc34
- sdaftuar approved
-
sdaftuar commented at 11:09 PM on March 15, 2018: member
utACK. I think this was just an oversight (perhaps leftover from my first implementation which didn't take advantage of ancestor-count-sorting to do the sort).
- sipa merged this on Mar 15, 2018
- sipa closed this on Mar 15, 2018
- sipa referenced this in commit df529dcc65 on Mar 15, 2018
- Mengerian referenced this in commit 2d00337ef7 on Aug 6, 2019
- PastaPastaPasta referenced this in commit 3ec86fdbeb on Jun 10, 2020
- PastaPastaPasta referenced this in commit 0144b2b0c0 on Jun 13, 2020
- PastaPastaPasta referenced this in commit 427e31d8ef on Jun 13, 2020
- PastaPastaPasta referenced this in commit 4fd7ef0b98 on Jun 13, 2020
- PastaPastaPasta referenced this in commit c94c99f6fa on Jun 17, 2020
- MarcoFalke locked this on Sep 8, 2021
Labels