Fix typos and cleanup in various files #12716

pull rex4539 wants to merge 1 commits into bitcoin:master from rex4539:fix-typos changing 44 files +55 −55

rex4539 commented at 2:29 PM on March 18, 2018: contributor

Unfortunately I messed up my repo while trying to squash #12593 so I created a PR with just the correct fixes.
fanquake added the label Docs on Mar 18, 2018
randolf changes_requested
randolf commented at 2:55 PM on March 18, 2018: contributor

These are excellent edits overall; please fix the following...

Line 4189 in src/wallet/wallet.cpp: Please change "the just generated" to either "the just-generated" or "this newly generated" (I prefer the latter).

Line 358 in test/functional/wallet_basic.py: Please revert this change.
rex4539 commented at 3:26 PM on March 18, 2018: contributor

@randolf Fixed :)
practicalswift commented at 5:37 PM on March 18, 2018: contributor

utACK 8cd373190c1dafc3c6ea660990e72ff4d7f20734

As said before – I think the inclusion of the capitalization fixes in src/core_write.cpp actually lowers the chance of getting this PR merged :-)

But utACK from me anyways :-)
randolf approved
hkjn commented at 12:00 PM on March 20, 2018: contributor

utACK 8cd3731.
promag commented at 10:36 PM on March 20, 2018: member

utACK 8cd3731.

in src/test/mempool_tests.cpp:526 in 8cd373190c outdated

 522 | @@ -523,7 +523,7 @@ BOOST_AUTO_TEST_CASE(MempoolSizeLimitTest)
 523 |      pool.addUnchecked(tx6.GetHash(), entry.Fee(1100LL).FromTx(tx6));
 524 |      pool.addUnchecked(tx7.GetHash(), entry.Fee(9000LL).FromTx(tx7));
 525 |  
 526 | -    // we only require this remove, at max, 2 txn, because its not clear what we're really optimizing for aside from that
 527 | +    // we only require this remove, at max, 2 txn, because it's not clear what we're really optimizing for aside from that

jnewbery commented at 10:43 PM on March 20, 2018:

nit: prefer 'we only require this to remove...' or 'we only require that this remove...'

in test/functional/wallet_basic.py:286 in 8cd373190c outdated

 282 | @@ -283,7 +283,7 @@ def run_test(self):
 283 |          sync_blocks(self.nodes[0:3])
 284 |          node_2_bal += 2
 285 |  
 286 | -        #tx should be added to balance because after restarting the nodes tx should be broadcastet
 287 | +        #tx should be added to balance because after restarting the nodes tx should be broadcasted

jnewbery commented at 10:48 PM on March 20, 2018:

nit: personal preference for broadcast as the past participle of broadcast (both are acceptable but broadcast appears to be more common: https://english.stackexchange.com/questions/33207/broadcast-or-broadcasted)

jnewbery commented at 10:48 PM on March 20, 2018: member

sure. utACK with a couple of nits.
Fix typos 4d9b4256d8
rex4539 commented at 6:36 AM on March 21, 2018: contributor

@jnewbery Fixed :)
hkjn commented at 2:40 PM on March 21, 2018: contributor

Re-utACK 4d9b425.
practicalswift commented at 3:10 PM on March 21, 2018: contributor

re-utACK 4d9b4256d89d1f7c6b3e4938ab2e89cde296e8e8
MarcoFalke merged this on Mar 21, 2018
MarcoFalke closed this on Mar 21, 2018
MarcoFalke referenced this in commit 4ad3b3c72c on Mar 21, 2018

in src/tinyformat.h:595 in 4d9b4256d8

 591 | @@ -592,7 +592,7 @@ inline const char* printFormatStringLiteral(std::ostream& out, const char* fmt)
 592 |  // Formatting options which can't be natively represented using the ostream
 593 |  // state are returned in spacePadPositive (for space padded positive numbers)
 594 |  // and ntrunc (for truncating conversions).  argIndex is incremented if
 595 | -// necessary to pull out variable width and precision .  The function returns a
 596 | +// necessary to pull out variable width and precision.  The function returns a

MarcoFalke commented at 3:40 PM on March 21, 2018:

Please submit the changes to this file upstream as well.

rex4539 commented at 4:31 PM on March 21, 2018:

https://github.com/c42f/tinyformat/pull/51

practicalswift commented at 3:48 PM on March 21, 2018: contributor

Nice to have this one merged!

Reviewers of this PR might be interested in reviewing #12747 which contains a few typo fixes :-)
rex4539 deleted the branch on Mar 21, 2018
jasonbcox referenced this in commit c1f172a401 on Sep 27, 2019
PastaPastaPasta referenced this in commit 2da7e1f032 on Jun 9, 2020
PastaPastaPasta referenced this in commit 8d37681a49 on Jun 9, 2020
PastaPastaPasta referenced this in commit 28d54440f7 on Jun 10, 2020
PastaPastaPasta referenced this in commit 88486d27ba on Jun 10, 2020
PastaPastaPasta referenced this in commit e30560588a on Jun 11, 2020
PastaPastaPasta referenced this in commit 262600e691 on Jun 11, 2020
PastaPastaPasta referenced this in commit 1921f98f9e on Jun 11, 2020
PastaPastaPasta referenced this in commit bb035972ee on Jun 12, 2020
gades referenced this in commit 9fc4a91b63 on Jun 30, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#12593 Fix typos and cleanup in various files