doc: add qrencode to brew install instructions #12850

pull 2a5A1Ghu1 wants to merge 1 commits into bitcoin:master from 2a5A1Ghu1:patch-1 changing 1 files +1 −1
  1. 2a5A1Ghu1 commented at 5:31 PM on April 1, 2018: none

    Build was missing qr code(qrencode libs) support and brew team no longer supports anything less than macOS 10.11

  2. fanquake added the label macOS on Apr 1, 2018
  3. fanquake commented at 11:56 PM on April 1, 2018: member

    Where are you seeing brew no longer supporting macOS < 10.11 ?

    On the brew website I see:

    10.10 or higher is recommended. 10.5–10.9 are supported on a best-effort basis. 
    For 10.4 see Tigerbrew.
    
  4. 2a5A1Ghu1 commented at 8:00 AM on April 2, 2018: none

    I see it when I run it in 10.8 - 10.10 using VM installs of 10.8, 10.9 and 10.10

    Also, ssl certs are not maintained anymore by apple and thus the ruby installer barely works if at all. There are workarounds but they are a pain in the behind.

    The brew team has not updated their website to reflect what is in their code.

    To reproduce the issue you will need to install each version of Mac OS X to confirm via VM or on an older machine. I will leave another comment later with screen shot soon.

  5. 2a5A1Ghu1 commented at 8:10 AM on April 2, 2018: none

    screen shot 2018-04-02 at 1 09 16 am

  6. fanquake commented at 7:07 AM on April 4, 2018: member

    @buddilla Thanks for the input, I'll put together some notes about EOL'ing support for macOS releases. However can you remove the changes you've made to the "Tested on" line. Our gitian built binaries still target a minimum of OS X 10.8.

  7. 2a5A1Ghu1 commented at 5:57 PM on April 4, 2018: none

    Changed I also added notes that 10.8 is still supported in gitian.

  8. 2a5A1Ghu1 commented at 9:40 PM on April 4, 2018: none

    I just realized that I misread what you wanted me to do(I just woke up at the time). Do you want me to revert the changes for the line "Tested on" back to Mac OS X 10.8... Or are the new changes better. The new changes may be better to help avoid further confusion for others, which means less issue posts. But this is your house so whatever you say goes. LOL

  9. 2a5A1Ghu1 commented at 11:05 PM on April 4, 2018: none

    I went ahead and changed it back below is what I added previously

    • Works with macOS 10.11 through 10.13 on 64-bit Intel processors only.

    • macOS 10.8 and higher is still supported on gitian builds

  10. fanquake commented at 1:04 AM on April 5, 2018: member

    Please squash your commits and update the commit message to something like "doc: add qrencode to brew install instructions"

  11. 2a5A1Ghu1 renamed this:
    Fixes Missing QRCode Build Update macOS Support
    doc: add qrencode to brew install instructions
    on Apr 5, 2018
  12. 2a5A1Ghu1 commented at 6:05 AM on April 5, 2018: none

    I am having a heck of a time trying to squash this. "Allow edits from maintainers" is checked. Any help would be appreciated.

  13. doc: add qrencode to brew install instructions
    Build was missing qr code(qrencode libs) support
    0314ad4e6d
  14. laanwj commented at 3:01 PM on April 7, 2018: member

    Squashed

  15. laanwj merged this on Apr 7, 2018
  16. laanwj closed this on Apr 7, 2018

  17. laanwj referenced this in commit 319991db5b on Apr 7, 2018
  18. 2a5A1Ghu1 deleted the branch on May 8, 2018
  19. MarcoFalke locked this on Sep 8, 2021
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me