travis: Run verify-commits only on cron jobs #12851

1. 
   MarcoFalke commented at 7:25 PM on April 1, 2018: member

   Since we skip travis builds on subsequent pushes (Auto Cancellation), there is no value in running verify-commits for non-cron jobs.

2. travis: Run verify-commits only on cron jobs fa6f12af6b
3. MarcoFalke added the label Tests on Apr 1, 2018
4. in .travis.yml:67 in fa6f12af6b

     63 | @@ -64,7 +64,7 @@ before_script:
     64 |      - if [ "$NEED_XVFB" = 1 ]; then export DISPLAY=:99.0; /sbin/start-stop-daemon --start --pidfile /tmp/custom_xvfb_99.pid --make-pidfile --background --exec /usr/bin/Xvfb -- :99 -ac; fi
     65 |  script:
     66 |      - if [ "$CHECK_DOC" = 1 -a "$TRAVIS_REPO_SLUG" = "bitcoin/bitcoin" -a "$TRAVIS_PULL_REQUEST" = "false" ]; then while read LINE; do travis_retry gpg --keyserver hkp://subset.pool.sks-keyservers.net --recv-keys $LINE; done < contrib/verify-commits/trusted-keys; fi
     67 | -    - if [ "$CHECK_DOC" = 1 -a "$TRAVIS_REPO_SLUG" = "bitcoin/bitcoin" -a "$TRAVIS_PULL_REQUEST" = "false" ]; then contrib/verify-commits/verify-commits.sh; fi
     68 | +    - if [ "$CHECK_DOC" = 1 -a "$TRAVIS_REPO_SLUG" = "bitcoin/bitcoin" -a "$TRAVIS_EVENT_TYPE" = "cron" ]; then travis_wait 30 contrib/verify-commits/verify-commits.sh; fi
   

   ---

   ---

   

   laanwj commented at 11:29 AM on April 2, 2018:

   Why the travis_wait?

5. laanwj requested review from TheBlueMatt on Apr 2, 2018
6. 
   laanwj commented at 2:48 PM on April 2, 2018: member

   verify-commits seems to often fail in travis on timeouts: https://travis-ci.org/bitcoin/bitcoin/jobs/361164386

   Please upgrade to at least gpg 2.1.10 to check for weak signatures
   Please upgrade to at least gpg 2.1.10 to check for weak signatures
   Please upgrade to at least gpg 2.1.10 to check for weak signatures
   Please upgrade to at least gpg 2.1.10 to check for weak signatures
   Please upgrade to at least gpg 2.1.10 to check for weak signatures
   ...
   No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
   Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
   The build has been terminated
   

   Is that the reason?

7. MarcoFalke merged this on Apr 4, 2018
8. MarcoFalke closed this on Apr 4, 2018

   ---

9. MarcoFalke referenced this in commit 648252e8ae on Apr 4, 2018
10. MarcoFalke deleted the branch on Apr 4, 2018
11. MarcoFalke locked this on Sep 8, 2021

Review Requested
TheBlueMatt