tests: Add note about test suite name uniqueness requirement to developer notes #12895

pull practicalswift wants to merge 3 commits into bitcoin:master from practicalswift:check-uniqueness-of-test-suite-names changing 5 files +23 −7

practicalswift commented at 8:34 PM on April 5, 2018: contributor
- Add documentation: Add note about test suite name uniqueness requirement in developer notes
- Add regression test: Update lint-tests.sh to make it check also for test suite name uniqueness
Context: #12894 (tests: Avoid test suite name collision in wallet crypto_tests)
MarcoFalke commented at 8:47 PM on April 5, 2018: member

Mind to add #12894 to this pull? (Keeps the number of open items to track down)
practicalswift force-pushed on Apr 5, 2018
practicalswift commented at 8:57 PM on April 5, 2018: contributor

@MarcoFalke Good idea! Done! :-)
fanquake added the label Tests on Apr 5, 2018
tests: Avoid test suite name collision in wallet crypto_tests 3ebfb2dadb
tests: Add note about uniqueness requirement for test suite names dc8067b3e6
tests: Add check for test suite name uniqueness in lint-tests.sh d1b622b5a2
practicalswift force-pushed on Apr 6, 2018
laanwj commented at 1:30 PM on April 7, 2018: member

utACK https://github.com/bitcoin/bitcoin/pull/12895/commits/d1b622b5a2dff5d68310bdf4e5d62d74e5391c25
MarcoFalke commented at 2:38 PM on April 7, 2018: member

utACK d1b622b
laanwj merged this on Apr 8, 2018
laanwj closed this on Apr 8, 2018
laanwj referenced this in commit d6f10b248a on Apr 8, 2018
PastaPastaPasta referenced this in commit bb4437261b on Jun 10, 2020
PastaPastaPasta referenced this in commit 9a0bb79540 on Jun 10, 2020
PastaPastaPasta referenced this in commit db44f19be5 on Jun 10, 2020
PastaPastaPasta referenced this in commit bd191d892d on Jun 11, 2020
PastaPastaPasta referenced this in commit 0c69bbf55d on Jun 11, 2020
PastaPastaPasta referenced this in commit 94bbadf82a on Jun 11, 2020
PastaPastaPasta referenced this in commit 9b9005e395 on Jun 12, 2020
practicalswift deleted the branch on Apr 10, 2021
gades referenced this in commit c6ff72c504 on Mar 8, 2022
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#12894 tests: Avoid test suite name collision in wallet crypto_tests