encryptwallet has address pool limitation? #12907

<!-- Describe the issue -->

in btc.conf keypool=200000

then I run bitcoin-cli encryptwallet "pass" will failed.

but when I change it into 2000, everything going fine.

<!--- What behavior did you expect? -->

<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->

<!--- How reliably can you reproduce the issue, what are the steps to do so? -->

<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->

<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->

<!-- Any extra information that might be useful in the debugging process. -->

<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

Please include the error message and version

bitcoin-0.16.0 and there is no error message, even no any message, it just made bitcoind exit.

Please note that " Successfully executing this command shuts down bitcoin core, it will need to be manually restarted. "

So, this is expected

Sorry, it is my fault. I didn't make a clear description. I know if the encryptwallet success, it will shut down bitcoind, and we should restart it manually. But, when I start bitcoind manually, again, the wallet is still NOT encrypted.

Can you please post your debug.log file? Also keypoolpool is not a valid option.

Sorry, typo, keypool And, I run a release binary...

Please check your debug.log for possible causes; Alternatively you can upload it here.

You can find the debug.log in your data dir.

Sorry I can not use the product system, so I built a test environment and run the test again. And sorry for I don't understand the log file, so I attached it. Hope it will be helpful. debug.log db.log

Thanks. I can reproduce on master (7e23972d1f715f596e61e6e3775a3ada75604497) with gdb --args ./src/qt/bitcoin-qt -datadir=/tmp/aaaa -keypool=200000 -regtest

The assert is hit here:

https://github.com/bitcoin/bitcoin/blob/7e23972d1f715f596e61e6e3775a3ada75604497/src/wallet/wallet.cpp#L643-L650

So it seems to return false in either of those:

https://github.com/bitcoin/bitcoin/blob/d889c036cd6f683116e6a27e404be2809d1deb76/src/wallet/crypter.cpp#L320-L323

The db.log file says it's running out of BDB locks. Is there really a fix for this other than changing the database system? We could limit the number of keypool entries or increase the number of locks, but those aren't really solutions.

I believe you can change the locks limit with a DB_CONFIG file which BDB will read and set the locks size. https://bitcointalk.org/index.php?topic=152208.0 may be of use (just googled around for those settings cause you ahve to apply them to pre-0.8 nodes to get them to sync the chain).

I can still reproduce. Probably getting rid of bdb is going to fix this #18916

Legacy wallets that use BDB are being deprecated. Using descriptor wallets should solve this problem.