tests: Avoid copies of CTransaction #12949

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1804-testNoCopyTx changing 10 files +39 −35

MarcoFalke commented at 5:54 PM on April 11, 2018: member

Avoid the copy (or move) constructor of CTransaction in test code, whereever a simple reference can be used instead.
MarcoFalke force-pushed on Apr 11, 2018
MarcoFalke force-pushed on Apr 11, 2018
tests: Avoid copies of CTransaction fae58eca93
MarcoFalke force-pushed on Apr 11, 2018
MarcoFalke commented at 7:02 PM on April 11, 2018: member

Force pushed fixes to the previously wrong comments about std::shared_ptr::use_count in blockencodings_tests.cpp
MarcoFalke added the label Tests on Apr 11, 2018
MarcoFalke added the label Refactoring on Apr 11, 2018
promag commented at 8:22 PM on April 11, 2018: member

utACK fae58ec. The fewer copies the better.
ryanofsky commented at 5:48 PM on April 13, 2018: member

utACK fae58eca934b5c7165b589c3bec1751d1b432b48
MarcoFalke merged this on Apr 17, 2018
MarcoFalke closed this on Apr 17, 2018
MarcoFalke referenced this in commit 6b46288a08 on Apr 17, 2018
MarcoFalke deleted the branch on Apr 17, 2018
PastaPastaPasta referenced this in commit a798e1e7e5 on Apr 13, 2021
PastaPastaPasta referenced this in commit fa864cc3b3 on Apr 15, 2021
PastaPastaPasta referenced this in commit ad0349ff96 on Apr 17, 2021
PastaPastaPasta referenced this in commit ab1b3759f4 on Apr 18, 2021
kittywhiskers referenced this in commit e4429abbf8 on Apr 23, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels