Drop IsCompressedOrUncompressedPubKey and IsCompressedPubKey #12959

pull Empact wants to merge 1 commits into bitcoin:master from Empact:is-compressed-or-uncompressed changing 2 files +16 −38

Empact commented at 12:51 AM on April 12, 2018: member

In favor of CPubKey methods. As of #12460, CPubKey::ValidSize tests relative to the header-relevant pubkey size, making it an appropriate replacement.

Note that this adds support for 2 new uncompressed header types to the CheckPubKeyEncoding pathway: values 6 and 7.

Drop IsCompressedOrUncompressedPubKey and IsCompressedPubKey

In favor of CPubKey methods. As of #12460, CPubKey::ValidSize tests relative
to the header-relevant pubkey sizes, making it an appropriate replacement.

Note that this adds support for 2 new uncompressed header types to the
IsCompressedOrUncompressedPubKey pathway: values 6 and 7.

078697b066

fanquake added the label Refactoring on Apr 12, 2018
Empact commented at 6:36 AM on April 12, 2018: member

Taking this down until I figure out the test failures...
Empact closed this on Apr 12, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Empact

Labels

Refactoring

Linked (view graph)

#12460 Assert CPubKey::ValidLength to the pubkey's header-relevant size