make CheckDiskSpace() use 50 * 1024 * 1024 Bytes #1296

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:CheckDiskSpace changing 2 files +5 −5

Diapolo commented at 5:50 AM on May 14, 2012: none
- remove 2 ugly spacess from a message string
gmaxwell commented at 6:03 AM on May 14, 2012: contributor

I'm somewhat inclined to back this way off— e.g. to 50 MiB or so, simply because of how badly it fails when it runs out and because 50MiB is pretty tiny compared to the blockchain.

in src/main.cpp:None in 31bb5b5d6e outdated

1845 | @@ -1846,10 +1846,10 @@ bool CheckDiskSpace(uint64 nAdditionalBytes)
1846 |      uint64 nFreeBytesAvailable = filesystem::space(GetDataDir()).available;
1847 |  
1848 |      // Check for 15MB because database could create another 10MB log file at any time
1849 | -    if (nFreeBytesAvailable < (uint64)15000000 + nAdditionalBytes)
1850 | +    if (nFreeBytesAvailable < (uint64)15728640 + nAdditionalBytes)

laanwj commented at 6:12 AM on May 14, 2012:

If you're going all the way to change it, please also make it a const instead of a magic value.

Diapolo commented at 6:34 AM on May 14, 2012: none

Updated to check for 50 MiB and make that a const uint64.
make CheckDiskSpace() use a global static const uint64 for checking required disk space and remove 2 ugly spaces from a message string 966ae00fe4
Diapolo commented at 12:35 PM on May 14, 2012: none

Updated to use a global constant (defined in main.h).
laanwj commented at 7:19 AM on May 15, 2012: member

ACK
luke-jr commented at 6:36 PM on May 18, 2012: member

ACK
gavinandresen referenced this in commit 973ca019bc on May 19, 2012
gavinandresen merged this on May 19, 2012
gavinandresen closed this on May 19, 2012
coblee referenced this in commit 9860a361b2 on Jul 17, 2012
lateminer referenced this in commit 85288e202f on Jan 22, 2019
lateminer referenced this in commit af895e920c on Jan 22, 2019
lateminer referenced this in commit 5e407c71cc on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors