Refactor g_wallet_init_interface to const reference #12977

pull promag wants to merge 2 commits into bitcoin:master from promag:2018-04-walletinitinterface changing 4 files +48 −50

promag commented at 1:09 PM on April 13, 2018: member

No description provided.
wallet: Make WalletInitInterface members const 1936125671
wallet: Refactor g_wallet_init_interface to const reference 6ec78f1461
promag commented at 1:10 PM on April 13, 2018: member

Requesting review from @sipa @laanwj and @jnewbery.
fanquake added the label Wallet on Apr 13, 2018
fanquake added the label Refactoring on Apr 13, 2018
practicalswift commented at 1:58 PM on April 13, 2018: contributor

Concept ACK
laanwj commented at 3:25 PM on April 13, 2018: member

I'm not convinced that this is worth changing at this point, at the least it may conflict with other wallet interface changes in process.
jnewbery commented at 4:00 PM on April 13, 2018: member

utACK 6ec78f146134be7ee067a25a412d3c927f9ac353
MarcoFalke commented at 4:59 PM on April 13, 2018: member

utACK 6ec78f146134be7ee067a25a412d3c927f9ac353
promag commented at 8:36 PM on April 13, 2018: member

it may conflict with other wallet interface change @laanwj I believe there are none? Anyway wallet interface is pretty new and if this is a good change then the sooner the better.
laanwj commented at 8:40 PM on April 13, 2018: member

Ok in that case concept ack...

On Fri, Apr 13, 2018, 22:36 João Barbosa notifications@github.com wrote:

it may conflict with other wallet interface change

@laanwj https://github.com/laanwj I believe there are none? Anyway wallet interface is pretty new and if this is a good change then the sooner the better.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/12977#issuecomment-381254167, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHutkH2WSnsXANjr5SJpmX4psMgYjfaks5toQxagaJpZM4TTbAY .
laanwj merged this on Apr 17, 2018
laanwj closed this on Apr 17, 2018
laanwj referenced this in commit 434150aef7 on Apr 17, 2018
PastaPastaPasta referenced this in commit ce86511bcd on Nov 10, 2020
PastaPastaPasta referenced this in commit 1335bc94c3 on Nov 12, 2020
PastaPastaPasta referenced this in commit f70e8bebcd on Nov 17, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels