No description provided.
test: Fix dangling wallet pointer in vpwallets #13007
pull promag wants to merge 1 commits into bitcoin:master from promag:2018-04-fixwallettest changing 1 files +3 −2-
promag commented at 5:31 PM on April 17, 2018: member
-
test: Fix dangling wallet pointer in vpwallets d41a420562
- MarcoFalke renamed this:
Fix dangling wallet pointer in vpwallets
test: Fix dangling wallet pointer in vpwallets
on Apr 17, 2018 - MarcoFalke added the label Tests on Apr 17, 2018
-
MarcoFalke commented at 9:21 PM on April 17, 2018: member
This is refactoring and doesn't fix a bug or anything?
- MarcoFalke added the label Refactoring on Apr 17, 2018
-
promag commented at 9:35 PM on April 17, 2018: member
No, I came across this "bad code" in a another branch and I thought this could already be "fixed". The first wallet is destroyed and it's pointer is kept in
vpwalletsbut later it's overwritten by another pointer. -
MarcoFalke commented at 10:09 PM on April 17, 2018: member
utACK d41a42056204d20b4413b1c78d26da56605bf34c. Code looks slightly cleaner, since the unused pointer is dropped after use.
- laanwj merged this on Apr 18, 2018
- laanwj closed this on Apr 18, 2018
- laanwj referenced this in commit 0d12570a80 on Apr 18, 2018
- UdjinM6 referenced this in commit 997e79439b on Aug 24, 2020
- PastaPastaPasta referenced this in commit b1a35b2d32 on Sep 8, 2020
- ckti referenced this in commit 17153885eb on Mar 28, 2021
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels