No description provided.
bench: Amend mempool_eviction test for witness txs #13013
pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1804-benchWitnessMempool changing 1 files +30 −11-
MarcoFalke commented at 11:53 PM on April 17, 2018: member
-
bench: Move constructors out of mempool_eviction hot loop 962d223e5c
-
bench: Amend mempool_eviction test for witness txs fa3bb183ad
- MarcoFalke added the label Tests on Apr 17, 2018
-
laanwj commented at 7:16 AM on April 18, 2018: member
Makes sense - utACK fa3bb183adaf086a70fbbe2bb1981f471a3281ce
-
MarcoFalke commented at 1:41 PM on April 18, 2018: member
Just for reference a plot of the benchmark results:
- The first commit (which obviously makes the loop faster by moving stuff out)
- The second commit (which makes slower due to witness)
- tag of version 0.16.0 for reference
-
MarcoFalke commented at 3:46 PM on April 24, 2018: member
@ryanofsky Any notes here, since you wrote the initial benchmark?
-
ryanofsky commented at 3:57 PM on April 24, 2018: member
utACK fa3bb183adaf086a70fbbe2bb1981f471a3281ce. I believe original benchmark was mostly a copy and paste of other test code.
- MarcoFalke merged this on Apr 24, 2018
- MarcoFalke closed this on Apr 24, 2018
- MarcoFalke referenced this in commit a0079d4b6d on Apr 24, 2018
- MarcoFalke deleted the branch on Apr 24, 2018
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels