Has been src/validation.cpp-only since 27afcd89db302d87168e0f504ee141dbf0e1ea22
Make AbortNode function static #13018
pull Empact wants to merge 1 commits into bitcoin:master from Empact:abort-node-static changing 1 files +2 −2-
Empact commented at 12:39 PM on April 18, 2018: member
-
1d6f162301
Make AbortNode function static
Has been src/validation.cpp-only since 27afcd89db302d87168e0f504ee141dbf0e1ea22
- fanquake added the label Refactoring on Apr 18, 2018
- fanquake added the label Validation on Apr 18, 2018
-
MarcoFalke commented at 1:00 PM on April 18, 2018: member
I fail to see how this makes a difference? I suggest closing the pull request according to the guidelines https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring
-
Empact commented at 1:05 PM on April 18, 2018: member
Fair enough, since it isn't declared elsewhere, it's already limited to this file. Static would just make that explicit / enforced.
- Empact closed this on Apr 18, 2018
- Empact deleted the branch on Apr 18, 2018
-
MarcoFalke commented at 1:12 PM on April 18, 2018: member
You'd had to add a section to the developer note style guide and get that accepted first, otherwise people will refactor the code back and forth to their own liking.
-
Empact commented at 1:21 PM on April 18, 2018: member
Ha - yeah my general sentiment is that more restrictive is better - const over non-const, static method over non-static. The idea here was to incrementally restrict the usage of CValidationState toward validation.cpp, and was prompted by questions from my looking into #13014.
-
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels