validation: Consistently use FormatStateMessage #13019

pull Empact wants to merge 1 commits into bitcoin:master from Empact:format-state-message changing 1 files +1 −1

Empact commented at 3:51 PM on April 18, 2018: member

To output CValidationState info.

This includes the reject reason and code as well as debug info.

Previously converted in #12356, but these snuck in since.
MarcoFalke commented at 4:30 PM on April 18, 2018: member

According to the guidelines, code changes are not [trivial]
MarcoFalke renamed this:
~~Trivial: Consistently use FormatStateMessage~~
validation: Consistently use FormatStateMessage
on Apr 18, 2018

in src/validation.cpp:3080 in 0c3bbe3243 outdated

3076 | @@ -3077,7 +3077,7 @@ bool CheckBlock(const CBlock& block, CValidationState& state, const Consensus::P
3077 |      for (const auto& tx : block.vtx)
3078 |          if (!CheckTransaction(*tx, state, false))
3079 |              return state.Invalid(false, state.GetRejectCode(), state.GetRejectReason(),
3080 | -                                 strprintf("Transaction check failed (tx hash %s) %s", tx->GetHash().ToString(), state.GetDebugMessage()));
3081 | +                                 strprintf("Transaction check failed (tx hash %s) (%s)", tx->GetHash().ToString(), FormatStateMessage(state)));

Empact commented at 4:44 PM on April 18, 2018:

Oh just realized this change is mistaken. Will revise.

Consistently use FormatStateMessage

To output CValidationState info.

This includes the reject reason and code as well as debug info.

5d12d0e722

Empact force-pushed on Apr 18, 2018
Empact commented at 6:58 PM on April 18, 2018: member

Closing as inconsequential.
Empact closed this on Apr 18, 2018
Empact deleted the branch on Apr 18, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Empact

MarcoFalke

Linked (view graph)

#12356 Fix 'mempool min fee not met' debug output