MOVEONLY: Move logging code from util.{h,cpp} to new files. #13021

1. 
   jimpo commented at 5:19 pm on April 18, 2018: contributor

   Split out first commit from #12954 to reduce amount of rebasing necessary.

   This introduces a cyclic dependency between logging and util that should be cleaned up in a future PR.

2. MOVEONLY: Move logging code from util.{h,cpp} to new files. b77b6e2345
3. MarcoFalke added the label Refactoring on Apr 18, 2018
4. 
   MarcoFalke commented at 5:39 pm on April 18, 2018: member

   utACK b77b6e23457dcbf160a3d586eca9df7a8d0bb351 (Lines are kept in the same order, which makes it easier to verify moveonly-ness)
5. 
   Empact commented at 9:14 pm on April 18, 2018: member

   utACK b77b6e2 also confirmed that the lines are repeated faithfully
6. 
   ajtowns commented at 2:25 am on April 20, 2018: member

   utACK b77b6e23457dcbf160a3d586eca9df7a8d0bb351

   Comparison with git diff HEAD^ --color-moved=zebra looks good. The cyclic dependency is logging.cpp to util.h to logging.h and there’s a plan for breaking that cycle in #12954. Agree that this would be good to merge soon, since it’s essentially a blocker for anything touching logging code.

7. 
   sipa commented at 4:58 am on April 20, 2018: member

   utACK b77b6e23457dcbf160a3d586eca9df7a8d0bb351. Verified move-only.
8. sipa merged this on Apr 20, 2018
9. sipa closed this on Apr 20, 2018

   ---

10. sipa referenced this in commit 8b262eb2d8 on Apr 20, 2018
11. jimpo deleted the branch on Apr 20, 2018
12. sipsorcery referenced this in commit 6fd771e946 on Apr 20, 2018
13. Fuzzbawls referenced this in commit c94f2412af on Apr 14, 2020
14. PastaPastaPasta referenced this in commit 12309092de on Jul 18, 2020
15. PastaPastaPasta referenced this in commit fb21ce6d7e on Jul 19, 2020
16. str4d referenced this in commit b42582395b on Oct 9, 2020
17. zkbot referenced this in commit ebc8de390c on Oct 9, 2020
18. gades referenced this in commit dcf9b6220e on Jun 30, 2021
19. MarcoFalke locked this on Sep 8, 2021

Contributors
jimpo MarcoFalke Empact ajtowns sipa

Labels
Refactoring