Split out first commit from #12954 to reduce amount of rebasing necessary.
This introduces a cyclic dependency between logging and util that should be cleaned up in a future PR.
MOVEONLY: Move logging code from util.{h,cpp} to new files. #13021
pull jimpo wants to merge 1 commits into bitcoin:master from jimpo:logging-files changing 5 files +412 −377-
jimpo commented at 5:19 PM on April 18, 2018: contributor
-
MOVEONLY: Move logging code from util.{h,cpp} to new files. b77b6e2345
- MarcoFalke added the label Refactoring on Apr 18, 2018
-
MarcoFalke commented at 5:39 PM on April 18, 2018: member
utACK b77b6e23457dcbf160a3d586eca9df7a8d0bb351 (Lines are kept in the same order, which makes it easier to verify moveonly-ness)
-
Empact commented at 9:14 PM on April 18, 2018: member
utACK b77b6e2 also confirmed that the lines are repeated faithfully
-
ajtowns commented at 2:25 AM on April 20, 2018: member
utACK b77b6e23457dcbf160a3d586eca9df7a8d0bb351
Comparison with
git diff HEAD^ --color-moved=zebralooks good. The cyclic dependency is logging.cpp to util.h to logging.h and there's a plan for breaking that cycle in #12954. Agree that this would be good to merge soon, since it's essentially a blocker for anything touching logging code. -
sipa commented at 4:58 AM on April 20, 2018: member
utACK b77b6e23457dcbf160a3d586eca9df7a8d0bb351. Verified move-only.
- sipa merged this on Apr 20, 2018
- sipa closed this on Apr 20, 2018
- sipa referenced this in commit 8b262eb2d8 on Apr 20, 2018
- jimpo deleted the branch on Apr 20, 2018
- sipsorcery referenced this in commit 6fd771e946 on Apr 20, 2018
- Fuzzbawls referenced this in commit c94f2412af on Apr 14, 2020
- PastaPastaPasta referenced this in commit 12309092de on Jul 18, 2020
- PastaPastaPasta referenced this in commit fb21ce6d7e on Jul 19, 2020
- str4d referenced this in commit b42582395b on Oct 9, 2020
- zkbot referenced this in commit ebc8de390c on Oct 9, 2020
- gades referenced this in commit dcf9b6220e on Jun 30, 2021
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels