In the midst of fighting with #12873 it became apparent that there're a number of assertions and print statements which are emitted by test nodes but don't identify the node in question. This change makes debugging a bit easier by adding identifying information to non-logger test_node-related error messages.
[qa] Attach node index to test_node AssertionError and print messages #13022
pull jamesob wants to merge 1 commits into bitcoin:master from jamesob:2018-04-18-func-test-debug-log changing 1 files +24 −13-
jamesob commented at 7:21 PM on April 18, 2018: member
- jamesob force-pushed on Apr 18, 2018
-
Empact commented at 9:27 PM on April 18, 2018: member
utACK da93b39
A few style nits (ymmv):
_with_node_idfeels like an implementation detail to me. A name like_node_msgcould be clear without being overly so.- For
raise_assertion- I'd either remove the indirection or apply it to all raises on the object, given they all use the node id treatment.
- fanquake added the label Tests on Apr 18, 2018
- jamesob force-pushed on Apr 19, 2018
- jamesob force-pushed on Apr 19, 2018
-
80a5e59532
[qa] Attach node index to test_node AssertionError and print messages
to aid debugging. Feedback incorporated from @Empact.
- jamesob force-pushed on Apr 19, 2018
-
skeees commented at 1:40 PM on April 22, 2018: contributor
concept ACK might also be useful to print out the ports that each node{k} is on - afaict those aren't printed anywhere - and very useful as each bitcoind log identifies peer by a different index and the only way that i'm aware of to tie these to the python test framework indexing is by port num
-
conscott commented at 12:45 PM on April 23, 2018: contributor
utACK 80a5e59532925a3445f523a8b3bc29e2e11e8848
- laanwj merged this on Apr 24, 2018
- laanwj closed this on Apr 24, 2018
- laanwj referenced this in commit 896a9d026c on Apr 24, 2018
- PastaPastaPasta referenced this in commit effe6d1263 on Nov 10, 2020
- PastaPastaPasta referenced this in commit 90d076846c on Nov 12, 2020
- PastaPastaPasta referenced this in commit 90038da3d9 on Nov 17, 2020
- MarcoFalke locked this on Sep 8, 2021
Labels