Dynamic wallet load / create / unload #13059

1. 
   jnewbery commented at 5:37 pm on April 23, 2018: member

   This meta-issue tracks the actions required to have full wallet load/create/unload at runtime.

   • Add locking to the global vpwallets to ensure no concurrency races when adding to the vector. This is sufficient thread safety for loadwallet and createwallet, but not unloadwallet (#13017 and #13028).
   • Add loadwallet RPC. Initially, this won’t update the available wallets in the GUI (#10740)
   • Hook up the loadwallet RPC to CClientUIInterface::LoadWallet() so newly loaded wallets are available in the GUI (#13097)
   • Add createwallet RPC. Initially, this won’t update the available wallets in the GUI (#13058)
   • Update vpwallets to be shared pointers (or similar) so that wallets can be freed safely (#13063).
   • Add unloadwallet RPC. Initially, this won’t update the available wallets in the GUI (#13111)
   • Hook up the unloadwallet RPC to a new CClientUIInterface::UnloadWallet() function so unloaded wallets are removed from the GUI (#13111)
   • Add an “open wallet” command in bitcoin-qt (#15153 and #15204)
   • Add a “close wallet” command in bitcoin-qt (#15195)
   • Add a “create wallet” command in bitcoin-qt (#15450)
2. fanquake added the label Wallet on Apr 23, 2018
3. fanquake added this to the milestone 0.17.0 on Apr 23, 2018
4. 
   promag commented at 6:23 pm on April 30, 2018: member

   Hook up the unloadwallet RPC to a new CClientUIInterface::UnloadWallet() function so unloaded wallets are removed from the GUI (no PR yet)

   Done #13111.

5. jnewbery added this to the "Issues" column in a project

   ---

6. laanwj added this to the "Blockers" column in a project

   ---

7. laanwj removed this from the "Blockers" column in a project

   ---

8. 
   jnewbery commented at 2:56 pm on June 21, 2018: member

   #13111 is merged.

   Final task is to add GUI menu items to open/close/create wallets. “Open wallet” is covered by #13100. @promag - what do you think about extending that PR to also cover closing/creating wallets?

9. 
   promag commented at 2:58 pm on June 21, 2018: member

   @jnewbery thought the same!
10. 
    jnewbery commented at 8:51 pm on June 27, 2018: member

    There’s a bug in the loadwallet implementation: #13552
11. 
    promag commented at 12:14 pm on July 17, 2018: member

    @jnewbery

    Add an “unload wallet” command in bitcoin-qt so wallets can be unloaded in the GUI (no PR yet)

    Done in #13100.

12. MarcoFalke removed this from the milestone 0.17.0 on Jul 29, 2018
13. 
    meshcollider commented at 3:03 am on February 13, 2019: contributor

    #15153 has been merged (open menu)
14. 
    jnewbery commented at 3:20 am on February 19, 2019: member

    #15195 merged \o/
15. MarcoFalke added this to the milestone 0.19.0 on Feb 19, 2019
16. 
    fanquake commented at 8:57 am on September 8, 2019: member

    #15450 has been merged (create wallet).
17. 
    Sjors commented at 9:36 am on September 16, 2019: member

    We should probably expand the scope with QT remembering which wallets were open in the previous session. E.g. #11082
18. 
    jnewbery commented at 1:39 pm on September 16, 2019: member

    We should probably expand the scope…

    Let’s keep this issue tracking the basic functionality of open/close/create wallets over RPC and in the GUI. Persisting which wallets are open in the GUI is a nice enhancement, but not a basic requirement.

19. MarcoFalke removed this from the milestone 0.19.0 on Sep 16, 2019
20. 
    MarcoFalke commented at 1:54 pm on September 16, 2019: member

    This has missed the deadline in #15940
21. meshcollider added this to the milestone 0.20.0 on Feb 10, 2020
22. laanwj removed this from the milestone 0.20.0 on Mar 26, 2020
23. laanwj added this to the milestone 0.21.0 on Mar 26, 2020
24. 
    promag commented at 9:06 pm on June 11, 2020: member

    I guess this can be closed after #15204.
25. MarcoFalke removed this from the milestone 0.21.0 on Jun 11, 2020
26. MarcoFalke added the label Feature on Jun 11, 2020
27. 
    Sjors commented at 11:30 am on June 16, 2020: member

    I think we close this now; that last ticket can stand on its own.
28. 
    promag commented at 11:34 am on June 16, 2020: member

    Sure.
29. jnewbery closed this on Jun 16, 2020

    ---

30. fanquake moved this from the "Issues" to the "Done" column in a project

    ---

31. DrahtBot locked this on Feb 15, 2022

Contributors
jnewbery promag meshcollider fanquake Sjors MarcoFalke

Labels
Feature Wallet