Make tests pass after 2020 #13061

pull bmwiedemann wants to merge 1 commits into bitcoin:master from bmwiedemann:ftbfs-2020 changing 1 files +2 −2
  1. bmwiedemann commented at 10:10 PM on April 23, 2018: contributor

    Make tests pass after 2020 and also test that 64 bit integers are properly handled

    Without this patch, the failure was

    unknown location(0): fatal error: in "rpc_tests/rpc_ban": std::runtime_error: JSON value is not an object as expected
    test/rpc_tests.cpp(260): last checkpoint
    

    I found this when testing reproducible builds for openSUSE Linux packages, building 15 years from now (this is the expected lifespan of today's software)

    There is 1 other issue in ./src/qt/test/paymentservertests.cpp that fails to verify a cert that expires in 2022 after 10y.

    QWARN  : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant: Payment request: certificate expired or not yet active:  QSslCertificate("3", "01", "Ipbt+DxK8RDQd25/5ueXqw==", (), ("Payment Request Test Merchant"), QMap(), QDateTime(2012-12-10 16:37:24.000 UTC Qt::TimeSpec(UTC)), QDateTime(2022-12-08 16:37:24.000 UTC Qt::TimeSpec(UTC)))
    FAIL!  : PaymentServerTests::paymentServerTests() Compared values are not the same
    
  2. Make tests pass after 2020
    also test that 64 bit integers are properly handled
    3ee4be1050
  3. fanquake added the label Tests on Apr 23, 2018
  4. laanwj commented at 5:56 AM on April 24, 2018: member

    Thanks. utACK 3ee4be10500710fc8e9b03acf974fd81224c05c4

    With the mention that it would be possible to avoid having this issue again forever (though 2283 is pretty much that) by using GetTime()+2y or so, or setting a mock time.

  5. practicalswift commented at 9:30 AM on April 24, 2018: contributor

    Very nice catch! Excellent first-time contribution! Hope to see more contributions from you.

    May I ask how you found this issue?

    utACK 3ee4be10500710fc8e9b03acf974fd81224c05c4

  6. MarcoFalke commented at 10:25 AM on April 24, 2018: member

    utACK 3ee4be10500710fc8e9b03acf974fd81224c05c4

  7. laanwj merged this on Apr 24, 2018
  8. laanwj closed this on Apr 24, 2018

  9. laanwj referenced this in commit 54865cf9e6 on Apr 24, 2018
  10. bmwiedemann commented at 4:20 AM on April 26, 2018: contributor

    @practicalswift I use the rbk script from https://github.com/bmwiedemann/reproducibleopensuse that invokes openSUSE's osc build with an option to pass -rtc base=$later to kvm. Alternatively one could just alter the host system clock.

  11. bmwiedemann deleted the branch on Apr 26, 2018
  12. MarcoFalke referenced this in commit 170b309981 on Jul 12, 2018
  13. deadalnix referenced this in commit 67bbd3d0aa on Mar 25, 2020
  14. PastaPastaPasta referenced this in commit c6f2490203 on Apr 12, 2020
  15. PastaPastaPasta referenced this in commit 15fb6dbf05 on Apr 16, 2020
  16. ftrader referenced this in commit 25ace521c1 on Aug 17, 2020
  17. random-zebra referenced this in commit a4fd2e1311 on Dec 13, 2020
  18. zkbot referenced this in commit e85265fbd5 on Feb 17, 2021
  19. zkbot referenced this in commit b4b07a1bbd on Feb 17, 2021
  20. ckti referenced this in commit ba042792a3 on Mar 28, 2021
  21. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me