[Policy] Fix MAX_STANDARD_TX_WEIGHT check #13096

pull jl2012 wants to merge 1 commits into bitcoin:master from jl2012:max_std_tx_weight changing 3 files +4 −4

jl2012 commented at 5:29 PM on April 26, 2018: contributor

As suggested by the constant name and its comment in policy.h, a transaction with a weight of exactly MAX_STANDARD_TX_WEIGHT should be allowed. Users could be confused.
MarcoFalke added the label TX fees and policy on Apr 26, 2018
fanquake commented at 5:37 PM on April 26, 2018: member

For reference this code was introduced in #2273.
laanwj commented at 6:44 PM on April 26, 2018: member

I don't think this matters in practice, but agree it's more consistent with the naming and documentation. utACK 492457f5c4ec3df5b8dc8dfed00a8236e3124f3b
MarcoFalke commented at 8:52 PM on April 26, 2018: member

If you adjust the condition for the mempool, please also adjust it for the wallet and p2p (orphan handling). You can use git grep MAX_STANDARD_TX_WEIGHT to find them.

Fix MAX_STANDARD_TX_WEIGHT check

As suggested by the constant name and its comment in policy.h, a transaction with a weight of exactly MAX_STANDARD_TX_WEIGHT should be allowed

2f1a30c63e

jl2012 force-pushed on May 4, 2018
jl2012 commented at 4:18 PM on May 4, 2018: contributor

@MarcoFalke fixed
MarcoFalke commented at 5:54 PM on May 4, 2018: member

Thanks. utACK 2f1a30c63e421b191c62059132b1cd40c24bd4d5
sipa commented at 9:43 PM on May 7, 2018: member

utACK 2f1a30c63e421b191c62059132b1cd40c24bd4d5
laanwj commented at 4:35 PM on July 5, 2018: member

re-utACK 2f1a30c63e421b191c62059132b1cd40c24bd4d5
laanwj merged this on Jul 5, 2018
laanwj closed this on Jul 5, 2018
laanwj referenced this in commit 062738cf69 on Jul 5, 2018
deadalnix referenced this in commit 7de90a0236 on Jun 9, 2020
ftrader referenced this in commit eb406532dc on Aug 17, 2020
sickpig referenced this in commit 5a38ab366d on Aug 18, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels