ui: Support wallets loaded dynamically #13097

pull promag wants to merge 3 commits into bitcoin:master from promag:2018-04-ui-wallet-loaded changing 3 files +35 −17
  1. promag commented at 5:31 pm on April 26, 2018: member
    Add support in the UI for wallets loaded dynamically.
  2. fanquake added the label Wallet on Apr 26, 2018
  3. promag force-pushed on Apr 26, 2018
  4. fanquake added the label GUI on Apr 26, 2018
  5. promag commented at 5:35 pm on April 26, 2018: member
    @ryanofsky had to convert interfaces::Wallet to shared pointer because of QueuedConnection. Do you have an alternative? Like instancing WalletModel on RPC thread and then make that the slot argument?
  6. promag force-pushed on Apr 26, 2018
  7. promag commented at 6:22 pm on April 26, 2018: member
    Previous version in promag/2018-04-ui-wallet-loaded.1, now WalletModel* is the argument in the queued connection.
  8. promag commented at 6:23 pm on April 26, 2018: member
    @jnewbery mind testing this?
  9. promag force-pushed on Apr 26, 2018
  10. promag force-pushed on Apr 26, 2018
  11. jnewbery commented at 9:26 pm on April 26, 2018: member

    @jnewbery mind testing this?

    Will do! (next week)

  12. promag commented at 9:27 pm on April 26, 2018: member

    In order to test, suppose there are wallets w1 and w2:

    • launch bitcoin-qt -regtest -nowallet
    • open console and run loadwallet w1 (should show wallet)
    • run loadwallet w2 (should show multi-wallet selector)
  13. in src/qt/bitcoin.cpp:254 in e15724a074 outdated 
    250@@ -250,7 +251,8 @@ public Q_SLOTS:
251     QTimer *pollShutdownTimer;
252 #ifdef ENABLE_WALLET
253     PaymentServer* paymentServer;
254-    std::vector<WalletModel*> m_wallet_models;
255+    std::list<WalletModel*> m_wallet_models;
    promag commented at 11:04 pm on April 26, 2018:
    Revert to vector.
  14. in src/qt/bitcoin.cpp:460 in e15724a074 outdated 
    455+    window->addWallet(walletModel);
456+    if (m_wallet_models.empty()) {
457+        window->setCurrentWallet(walletModel->getWalletName());
458+    }
459+
460+    connect(walletModel, SIGNAL(coinsSent(WalletModel*,SendCoinsRecipient,QByteArray)),
    promag commented at 11:05 pm on April 26, 2018:
    Improve format.
  15. promag force-pushed on Apr 27, 2018
  16. jnewbery commented at 4:00 pm on April 30, 2018: member

    Please update title to indicate that this PR is for GUI support for wallets loaded at runtime.

    Please rebase on #10740 (which I just rebased on master) to pick up the wallet: Make vpwallets usage thread safe commit

  17. promag renamed this:
    Support wallets loaded dynamically
    ui: Support wallets loaded dynamically
    on Apr 30, 2018
  18. promag force-pushed on Apr 30, 2018
  19. promag commented at 4:06 pm on April 30, 2018: member
    @jnewbery done.
  20. jnewbery commented at 6:08 pm on April 30, 2018: member
    Tested ACK c9048b9213f7e9dc9b8da9b06c2caccd27f8c3cc
  21. jnewbery commented at 8:56 pm on April 30, 2018: member
    This (and #13100) need to update doc/release-notes-pr10740.md to state that dynamic wallet loading is supported in the GUI.
  22. promag force-pushed on May 1, 2018
  23. promag commented at 9:14 pm on May 1, 2018: member
    @jnewbery done (here).
  24. meshcollider commented at 9:13 am on May 2, 2018: contributor
    Concept ACK
  25. laanwj added this to the "Blockers" column in a project
  26. jnewbery added this to the "In progress" column in a project
  27. jnewbery commented at 9:53 pm on May 4, 2018: member
    @promag - this requires a rebase for one of my commits. I’ve rebased #10740. I suggest you reset to that branch and then cherrypick your commits.
  28. promag force-pushed on May 4, 2018
  29. promag commented at 10:01 pm on May 4, 2018: member
    @jnewbery rebased.
  30. ui: Remove unnecessary variable fFirstWallet 1c8fe0bf90
  31. ui: Support wallets loaded dynamically 0e674ba557
  32. promag force-pushed on May 16, 2018
  33. promag commented at 7:49 pm on May 16, 2018: member
    Rebased.
  34. mess110 commented at 10:16 pm on May 16, 2018: contributor
    Tested ACK 0e674ba
  35. jnewbery commented at 6:57 pm on May 17, 2018: member
    Tested ACK 0e674ba5572275bcc1eb8f91c6292f871925f965
  36. jonasschnelli commented at 7:51 pm on May 17, 2018: contributor
    Started in regtest with only the “default” wallet loaded (single wallet mode), then, loaded another wallet. I could see the 2nd wallet, but the initial “default” wallet did had no name in the dropdown.
  37. jonasschnelli commented at 7:59 pm on May 17, 2018: contributor

    If you load a wallet when you are in the “Receive”-Tab (or any other tab), select the wallet via the Dropdown the “Overview”-view will appear instead of the “Receive”-View.

  38. jonasschnelli commented at 8:01 pm on May 17, 2018: contributor
    utACK 0e674ba5572275bcc1eb8f91c6292f871925f965 though I would prefer if the glitches would be fixed before merge
  39. jnewbery commented at 8:13 pm on May 17, 2018: member

    the initial “default” wallet did had no name in the dropdown.

    Yes - this is a result of #11687 (review) , and is also visible in the listwallets and getwalletinfo RPC calls.

    This PR does introduce that behaviour, but does make it more visible when loading a second wallet.

  40. promag commented at 11:27 pm on May 17, 2018: member
    @jonasschnelli launching with bitcoin-qt -regtest -wallet -wallet=w1 also adds an empty item to the checkbox.
  41. fixup! ui: Support wallets loaded dynamically 2e75134719
  42. promag commented at 11:48 pm on May 17, 2018: member
    @jonasschnelli care to test again? Will squash after that.
  43. jonasschnelli commented at 8:10 am on May 18, 2018: contributor
    Tested ACK 2e751347190049ac1b7fb8378db004956700aaa1
  44. jonasschnelli merged this on May 18, 2018
  45. jonasschnelli closed this on May 18, 2018
  46. jonasschnelli referenced this in commit e54550303b on May 18, 2018
  47. laanwj removed this from the "Blockers" column in a project
  48. promag deleted the branch on May 20, 2018
  49. fanquake moved this from the "In progress" to the "Done" column in a project
  50. ken2812221 commented at 3:41 pm on June 19, 2018: contributor

    default default

    If wallet failed to load because of pruned mode, the dropdown menu shows the wallet.

  51. MarcoFalke referenced this in commit 6579d80572 on Jun 20, 2018
  52. jasonbcox referenced this in commit 482ae43a56 on Oct 25, 2019
  53. jasonbcox referenced this in commit 962952f31a on Oct 25, 2019
  54. PastaPastaPasta referenced this in commit 40964a51cf on Dec 16, 2020
  55. PastaPastaPasta referenced this in commit 5d483106f8 on Dec 16, 2020
  56. PastaPastaPasta referenced this in commit b49405bcd9 on Dec 18, 2020
  57. PastaPastaPasta referenced this in commit ce5b06ed66 on Dec 18, 2020
  58. xdustinface referenced this in commit a34ac73dd2 on Apr 4, 2021
  59. xdustinface referenced this in commit af40021c9f on Apr 4, 2021
  60. xdustinface referenced this in commit 713e241b6f on Apr 4, 2021
  61. xdustinface referenced this in commit d84ee328ff on Apr 4, 2021
  62. xdustinface referenced this in commit 773e39e1e5 on Apr 5, 2021
  63. xdustinface referenced this in commit a8454e22b0 on Apr 13, 2021
  64. DrahtBot locked this on Sep 8, 2021


promag jnewbery meshcollider mess110 jonasschnelli ken2812221

Labels
GUI Wallet

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-18 21:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me