tests: Make it clear that MAX_INV_SZ is not covered by functional tests #13113

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:add-note-about-MAX_INV_SZ changing 1 files +3 −1

practicalswift commented at 12:06 PM on April 29, 2018: contributor

Make it clear that MAX_INV_SZ is not covered by functional tests.
tests: Make it clear that MAX_INV_SZ is not covered by functional tests 2cefcb2f91
fanquake added the label Tests on Apr 29, 2018

in test/functional/test_framework/messages.py:34 in 2cefcb2f91

  30 | @@ -31,7 +31,9 @@
  31 |  MY_SUBVERSION = b"/python-mininode-tester:0.0.3/"
  32 |  MY_RELAY = 1 # from version 70001 onwards, fRelay should be appended to version messages (BIP37)
  33 |  
  34 | -MAX_INV_SZ = 50000
  35 | +# TODO: Add a test that uses MAX_INV_SZ - e.g. tests that this is the maximum number of INVs returned

MarcoFalke commented at 12:57 PM on April 29, 2018:

I think it would be easier if you just added that test. Would be trivial to send a getdata or inv with that many entries and assert that we don't hear back from them.

laanwj commented at 6:45 AM on April 30, 2018: member
Agree with @marcofalke, I don't think this requires a code change. Please either:
- Bite the bullet and create the test
- Create an issue to track missing tests, and mention this one
laanwj closed this on Apr 30, 2018
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels