[tests] Fix flake8 warnings in several wallet functional tests #13136

1. 
   jnewbery commented at 3:11 pm on May 1, 2018: member

   Fixes flake8 warnings in several wallet functional tests.

   Several wallet functional tests need rewrite to remove the accounts API (#13075). To prepare for that, I fixed all the flake8 warnings in those tests.

   #13075 is blocked on a bitcoind bug. This PR is just the flake8 fixes so we’re not completely blocked.

2. in test/functional/wallet_basic.py:236 in 5ec11f44f3 outdated

   237+        # 2. hex-changed one output to 0.0
   238+        # 3. sign and send
   239+        # 4. check if recipient (node0) can list the zero value tx
   240         usp = self.nodes[1].listunspent()
   241-        inputs = [{"txid":usp[0]['txid'], "vout":usp[0]['vout']}]
   242+        inputs = [{"txid": usp[0]['txid'], "vout":usp[0]['vout']}]
   

   ---

   ---

   

   MarcoFalke commented at 3:17 pm on May 1, 2018:

   If you add a space here, then make it consistently for the second kv as well
3. in test/functional/wallet_listtransactions.py:139 in 5ec11f44f3 outdated

   135@@ -129,21 +136,21 @@ def get_unconfirmed_utxo_entry(node, txid_to_match):
   136         assert_equal(utxo_to_use["safe"], False)
   137 
   138         # Create tx2 using createrawtransaction
   139-        inputs = [{"txid":utxo_to_use["txid"], "vout":utxo_to_use["vout"]}]
   140+        inputs = [{"txid": utxo_to_use["txid"], "vout":utxo_to_use["vout"]}]
   

   ---

   ---

   

   MarcoFalke commented at 3:17 pm on May 1, 2018:

   same here
4. 
   MarcoFalke commented at 3:19 pm on May 1, 2018: member

   utACK 5ec11f44f322be851746903578bd5224b9807e51. I am not aware of any significant pull request that would conflict due to this, so it seems fine.
5. 
   ryanofsky commented at 3:27 pm on May 1, 2018: member

   utACK 5ec11f44f322be851746903578bd5224b9807e51
6. [tests] Fix flake8 warnings in several wallet functional tests

   This commit fixes flake8 warnings in the following functional tests:
   
   - wallet_listreceivedby.py
   - wallet_basic.py
   - wallet_txn_clone.py
   - wallet_listsinceblock.py
   - wallet_import_rescan.py
   - wallet_listtransactions.py
   - wallet_importprunedfunds.py
   - wallet_txn_doublspend.py

   a533834d50
7. jnewbery force-pushed on May 1, 2018
8. 
   jnewbery commented at 3:35 pm on May 1, 2018: member

   @MarcoFalke - addressed your comments. I’ve also fixed a couple of variable names which I somehow missed before. @ryanofsky - Thanks for the quick review. git diff 5ec11f4 a533834d should be minimal
9. 
   MarcoFalke commented at 3:42 pm on May 1, 2018: member

   re-utACK a533834d502ef72aa14216828ae0ff5c7fc5625e
10. 
    ryanofsky commented at 3:59 pm on May 1, 2018: member

    utACK a533834d502ef72aa14216828ae0ff5c7fc5625e
11. 
    MarcoFalke commented at 4:16 pm on May 1, 2018: member

    Note that this is no longer [trivial] since you change variable names and remove assignments…
12. MarcoFalke renamed this:
    [trivial] [tests] Fix flake8 warnings in several wallet functional tests
    [tests] Fix flake8 warnings in several wallet functional tests
    on May 1, 2018
13. MarcoFalke merged this on May 1, 2018
14. MarcoFalke closed this on May 1, 2018

    ---

15. MarcoFalke referenced this in commit baf6b4e3f9 on May 1, 2018
16. jnewbery deleted the branch on May 1, 2018
17. jasonbcox referenced this in commit 66978e8510 on Oct 1, 2020
18. UdjinM6 referenced this in commit 3d55b81198 on May 21, 2021
19. UdjinM6 referenced this in commit f1ec546b35 on May 25, 2021
20. TheArbitrator referenced this in commit 3a58e04762 on Jun 4, 2021
21. MarcoFalke locked this on Sep 8, 2021

Contributors
jnewbery MarcoFalke ryanofsky