GUI: add 2 labels to the overviewpage that display Wallet and Transaction status #1314

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Wallet_Transaction_state_Overviewpage changing 4 files +98 −46

Diapolo commented at 3:00 PM on May 15, 2012: none
- cleanup overviewpage XML ui-file
- addresses: #1236
laanwj commented at 7:48 PM on May 16, 2012: member

The idea is great, however I don't think "obsolete" is the word to use here. It has very negative connotations.

Also, it would be nice if the tooltip explanation was more verbose, and explained to the user that they should wait until they catch up with the block chain until they can rely on the numbers shown (and not panic :-).
Diapolo commented at 8:04 AM on May 17, 2012: none

You are right, we should not scare users ^^. Will change the strings.
Diapolo commented at 8:19 AM on May 17, 2012: none

Updated to be less scaring and more verbose.
Diapolo commented at 1:00 PM on May 17, 2012: none

I'm tuning the layout a little currently, please wait for a final rebase before merging @laanwj.
Diapolo commented at 1:24 PM on May 17, 2012: none

Updated tooltip once more, changed tr() handling, to not need to translate "(" and ")" and fixed use stylesheet in the UI-file. If @laanwj you feel the text is now better this can be merged.
laanwj commented at 1:51 PM on May 17, 2012: member
I think at least one native English speaker should check this, but some remarks:
- Never display "(up to date)". Only display "(out of sync)" when the block chain is out of sync. After all, there is never a guarantee that the client is up to date, only an indication that it is not. See the original issue #1236.
- Message: Wallet state, displays "out of sync" while block chain sync needs to be done and "up to date", if the local block chain is synced to the network. Remember, "out of sync" is a normal state, no Bitcoins are lost!:
  
  No need to mention "wallet state", or "no bitcoins are lost!". I think it is better to show the message (when the user hovers over any "out of sync"), as:
  
  The displayed information reflects an older state. The local block chain needs to be synchronized to the network to get more recent information. This will happen automatically when there is connectivity to the network.
  
  Show no message when not out of sync
I think the message can be even more simpler and more verbose/friendly English, but this is the idea.
Diapolo commented at 2:14 PM on May 17, 2012: none

I agree to hide the message if everything is okay ... will update. Have to think about the message-text again ;) ... will take your suggestion as base.
Diapolo commented at 3:03 PM on May 17, 2012: none

@laanwj My suggestion is: <b>The displayed information reflects an older state. To get more recent information, the local block chain needs to be synced with the network. This process starts automatically after a network connection is established.</b>
laanwj commented at 4:08 PM on May 17, 2012: member

Yes, ok with me. (btw, you have a space before the message in your commit :-)
Diapolo commented at 4:12 PM on May 17, 2012: none

@laanwj OMFG that needs an update :), thanks for mentioning!
Diapolo commented at 4:14 PM on May 17, 2012: none

Finished :-D!?
in src/qt/overviewpage.cpp:None in 02ffc1aada outdated
```
 177 | @@ -169,3 +178,15 @@ void OverviewPage::displayUnitChanged()
 178 |      txdelegate->unit = model->getOptionsModel()->getDisplayUnit();
 179 |      ui->listTransactions->update();
 180 |  }
 181 | +
 182 | +void OverviewPage::showStatusNotOk()
```
laanwj commented at 4:20 PM on May 17, 2012:

I suggest using one function that takes a boolean

Diapolo commented at 4:33 PM on May 17, 2012:

Good point!

Diapolo commented at 4:41 PM on May 17, 2012:

Updated to be a single function.
laanwj commented at 4:38 PM on May 17, 2012: member

As for the messages, maybe it'd be good if @gmaxwell takes a look too. He opened the original issue.
add 2 labels to the overviewpage that display Wallet and Transaction status (obsolete or current) / cleanup overviewpage XML ui-file c26f3a9bd1
Diapolo commented at 7:50 PM on May 17, 2012: none

Updated to @gmaxwell phrasing suggestion.
laanwj referenced this in commit f0fc95a143 on May 17, 2012
laanwj merged this on May 17, 2012
laanwj closed this on May 17, 2012
coblee referenced this in commit 42aee554ea on Jul 17, 2012
suprnurd referenced this in commit cedd269cb0 on Dec 5, 2017
lateminer referenced this in commit eac6313ae6 on Jan 22, 2019
lateminer referenced this in commit 185194bd7e on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

Linked (view graph)

#1236 Usability: During initial sync its not obvious that txn will not be displayed #1346 Restore overview page (put transactions back within frame)