MSVC fails to compile with the changes made in #10742
The problem is enum types were changed to scoped (enum class) but in some places enum as an unscoped is used.
This is a very simple fix and I've tested it.
Edit: Had to remove enum altogether - enum class doesn't compile on clang.
32 | @@ -33,7 +33,7 @@ enum class RetFormat { 33 | }; 34 | 35 | static const struct { 36 | - enum RetFormat rf; 37 | + enum class RetFormat rf;
Fails on clang with:
rest.cpp:36:10: error: reference to scoped enumeration must use 'enum' not 'enum class'
enum class RetFormat rf;
^~~~~~
rest.cpp:71:13: error: reference to scoped enumeration must use 'enum' not 'enum class'
static enum class RetFormat ParseDataFormat(std::string& param, const std::string& strReq)
^~~~~~
2 errors generated.
argh should have gone with my first version (just removing enum altogether!).
I'll update the PR soon. Thanks!
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
Okay - done finally (Got my branch into a messed up state which automatically closed the PR) :(
utACK 43f3dec009c43c0df2ef4ff62a9327de0148d959
utACK 43f3dec009c43c0df2ef4ff62a9327de0148d959
Thanks for fixing this!
utACK 43f3dec.
utACK 43f3dec009c43c0df2ef4ff62a9327de0148d959