[WIP] Refactoring platform-specific code in util.h/util.cpp #13196

pull glaksmono wants to merge 9 commits into bitcoin:master from glaksmono:bitcoin-12697 changing 20 files +592 −37
  1. glaksmono commented at 6:15 AM on May 9, 2018: contributor

    Take all of the functions that are specific to Windows or Unix, and create a common set of methods in a new header file, all combined in the src/util/ folder.

    The goal of this PR is to break src/util.cpp and src/util.h into the following files:

    For Windows:

    • src/util/platform_windows.h
    • src/util/platform_windows.cpp

    For Mac & Linux:

    • src/util/platform_posix.h
    • src/util/platform_posix.cpp

    Issue Reference: #12697

  2. fanquake added the label Refactoring on May 9, 2018
  3. fanquake added the label Utils/log/libs on May 9, 2018
  4. fanquake commented at 6:46 AM on May 9, 2018: member

    @glaksmono Thanks for wanting to work on #12697. For future reference, ideally [WIP] PRs should only be opened when some code has been written, and you need help/feedback in regards to code or design decisions. We don't really use them for "claiming" issues to work on, a comment in the relevant issue is enough for that. (they will also consume Travis resources unnecessarily).

  5. glaksmono commented at 7:16 AM on May 9, 2018: contributor

    Got it @fanquake apologise. Will keep that in mind for the future.

  6. tests: Add test for 64-bit PE, modify 32-bit test results
    9a75d29b6f0d6c4834e451b0fae2200786655a35 change the error result from `PIE` to `DYNAMIC_BASE`. And there are no test for 64-bit, so I made one
    292bd8d4da
  7. RPC Docs: gettxout*: clarify bestblock and unspent counts c57612f754
  8. -includeconf=<path> support in config handler, for including external configuration files db2b9c5dcd
  9. test: Test includeconf parameter. e6d8878263
  10. doc: Add release notes for -includeconf c2e6096996
  11. [bitcoin-11004] creating another jobs for the CHECK_DOC=1, separated from the core jobs a33b773a3c
  12. [test] fundrawtransaction: lock watch-only shared address
    self.nodes[0] creates an address which is watch-only-shared with self.nodes[3]. If nodes[0] spends the associated UTXO during any of its sends later, the watchonly test will fail, as nodes[3] now has insufficient funds.
    
    Note that this also adds a new find_vout_for_address function to the test framework.
    b93ad3daf2
  13. qa: Remove unused option --srcdir 1ab3a2f0bf
  14. Refactoring platform-specific code in util.h/util.cpp 6cc7d935b5
  15. glaksmono force-pushed on May 9, 2018
  16. glaksmono closed this on May 9, 2018

  17. glaksmono deleted the branch on May 9, 2018
  18. glaksmono restored the branch on May 9, 2018
  19. glaksmono reopened this on May 9, 2018

  20. glaksmono closed this on May 9, 2018

  21. glaksmono deleted the branch on May 9, 2018
  22. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me