refactor: Extract BnB-specific data from CInputCoin #13223

pull Empact wants to merge 1 commits into bitcoin:master from Empact:duplicate-fee-calc changing 5 files +46 −29

Empact commented at 11:58 PM on May 12, 2018: member

This separates the fee-specific info of CInputCoin that are only used by SelectCoinsBnB into a separate wrapper class. This makes CInputCoin small and allows for isolation and expression of BnB-specific concepts like waste.

This also calls attention to the fact that there is no fee-specific testing of SelectCoinsBnB currently. Could be worthy to visit for greater coverage.
Empact commented at 12:05 AM on May 13, 2018: member

/cc @achow101
fanquake added the label Wallet on May 13, 2018
Empact force-pushed on May 13, 2018
Empact renamed this:
~~refactor: Accept fee argument to CInputCoin constructor~~
refactor: Accept fee & long_term_fee arguments to CInputCoin constructor
on May 13, 2018
Empact force-pushed on May 13, 2018

refactor: Extract BnB-specific data from CInputCoin

This separates the fee-specific info of CInputCoin that are only used by
SelectCoinsBnB into a separate wrapper class. This makes CInputCoin small and
allows for isolation and expression of BnB-specific concepts like waste.

This also calls attention to the fact that there is no fee-specific testing of
SelectCoinsBnB currently. Could be worthy to visit for greater coverage.

c9e48ecd0c

Empact force-pushed on May 13, 2018
Empact renamed this:
~~refactor: Accept fee & long_term_fee arguments to CInputCoin constructor~~
refactor: Extract BnB-specific data from CInputCoin
on May 13, 2018
Empact commented at 12:34 AM on May 16, 2018: member

Closing due to many other more meaningful PRs
Empact closed this on May 16, 2018
Empact deleted the branch on May 16, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Empact

Labels

Wallet