[qt] Satoshi unit #13264

pull GreatSock wants to merge 2 commits into bitcoin:master from GreatSock:satoshis changing 2 files +20 −7

GreatSock commented at 2:39 PM on May 17, 2018: contributor

This adds satoshi as an additional amount unit for the GUI.

[qt] BitcoinUnits::format with zero decimals

Formatting with zero decimals will now result in 123 instead of 123.0

4ddbcbf8c4

[qt] Added satoshi unit

"Satoshi (sat)" will be displayed in dropdowns and status bars.
"sat" will be used when appended to numbers.

c722f00a7e

mess110 commented at 4:16 PM on May 17, 2018: contributor

ACK https://github.com/bitcoin/bitcoin/pull/13264/commits/c722f00a7e3d638253ef7ba59fcef123fcfd94b0
kristapsk commented at 4:19 PM on May 17, 2018: contributor

utACK c722f00a7e3d638253ef7ba59fcef123fcfd94b0
in src/qt/bitcoinunits.cpp:57 in c722f00a7e
```
  54 | @@ -52,7 +55,8 @@ QString BitcoinUnits::shortName(int unit)
  55 |      switch(unit)
  56 |      {
  57 |      case uBTC: return QString::fromUtf8("bits");
```
Empact commented at 4:22 PM on May 17, 2018:

I guess the fromUtf8 calls is unnecessary here?

GreatSock commented at 4:34 PM on May 17, 2018:

Seems so. Should I make a commit to get rid of it?

laanwj commented at 4:51 PM on May 17, 2018:

it's unnecessary but also doesn't really matter, there's no more overhead than QString(...) and anyway, it's not a performance critical function.
Empact commented at 4:24 PM on May 17, 2018: member

utACK c722f00
ken2812221 commented at 4:31 PM on May 17, 2018: contributor

Concept ACK
laanwj added the label GUI on May 17, 2018
laanwj commented at 4:56 PM on May 17, 2018: member

utACK c722f00a7e3d638253ef7ba59fcef123fcfd94b0
MarcoFalke commented at 5:10 PM on May 17, 2018: member

utACK c722f00
kallewoof approved
kallewoof commented at 5:32 AM on May 18, 2018: member

utACK c722f00a7e3d638253ef7ba59fcef123fcfd94b0
jonasschnelli commented at 7:05 AM on May 18, 2018: contributor

Tested ACK c722f00a7e3d638253ef7ba59fcef123fcfd94b0
jonasschnelli merged this on May 18, 2018
jonasschnelli closed this on May 18, 2018
jonasschnelli referenced this in commit 2a7c53bc2a on May 18, 2018
GreatSock deleted the branch on May 18, 2018
sipa added the label Needs release notes on Aug 14, 2018
fanquake removed the label Needs release note on Mar 20, 2019
deadalnix referenced this in commit 7ff1309f12 on Mar 5, 2020
ftrader referenced this in commit c929cdeb0e on Apr 16, 2020
UdjinM6 referenced this in commit e2cc851cc3 on Jun 18, 2021
TheArbitrator referenced this in commit 1f4e302971 on Jun 21, 2021
UdjinM6 referenced this in commit 3f6c536df8 on Jun 24, 2021
UdjinM6 referenced this in commit d456128f0b on Jun 29, 2021
UdjinM6 referenced this in commit 735df516b9 on Jun 29, 2021
UdjinM6 referenced this in commit 6df96f0065 on Jul 2, 2021
UdjinM6 referenced this in commit a0241c1f2f on Jul 4, 2021
UdjinM6 referenced this in commit ee5ec0077b on Jul 6, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels