[qt] Fixed tx-view min amount typing period on locales using comma #13278

pull GreatSock wants to merge 2 commits into bitcoin:master from GreatSock:minamount-fix changing 1 files +21 −3
  1. GreatSock commented at 10:36 pm on May 18, 2018: contributor

    This allows the user to enter periods into the “Min amount” box in the transaction view on locales using commas. Previously only commas could be entered, which does not work.

    Now when a comma is typed it will also be automatically translated into a period.

  2. [qt] Tx-view min amount allow typing period
    Fixed not being able to type a period in the transaction view "Min amount" box on locales using comma.
    Now you can only enter periods, but not commas.
    08920d1678
  3. [qt] Tx-view min amount translate commas
    When a comma is typed in the transaction view "Min amount" box it will be automatically translated into a period.
    b2e232d31f
  4. fanquake added the label GUI on May 19, 2018
  5. practicalswift commented at 8:43 am on May 19, 2018: contributor

    I’m trying to understand the Qt code here.

    If the Qt client is supposed to be culture aware when it comes to handling of the radix point, shouldn’t we let the locale machinery handle it throughout to make the radix point handling consistent?

    (Also, very theoretically the user could be using an exotic evil locale with a radix point other than . and , .-))

  6. GreatSock commented at 9:34 am on May 19, 2018: contributor

    It now works like any other place an amount is entered. So it should be consistent everywhere now.

    And even if the user is using some weird locale it’ll still allow them to type a period using the period key(or even the comma key). Before it would only let them type their locale’s radix point which would not result in a valid number.

  7. promag commented at 11:02 am on May 19, 2018: member
    Concept ACK. This also allows copy&paste.
  8. jonasschnelli commented at 8:42 am on May 25, 2018: contributor
    Yes. Why not. Concept ACK
  9. DrahtBot commented at 2:19 pm on June 24, 2018: member
  10. DrahtBot added the label Needs rebase on Jun 24, 2018
  11. hebasto commented at 5:48 am on September 23, 2018: member
    NACK: too complex for a locale related issue.
  12. MarcoFalke commented at 8:37 pm on September 24, 2018: member
    No activity in more than 2 months. Let me know when you want to work on this again and I can reopen.
  13. MarcoFalke closed this on Sep 24, 2018

  14. laanwj removed the label Needs rebase on Oct 24, 2019
  15. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-04 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me