UPnP #133
pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:upnp changing 30 files +362 −32-
TheBlueMatt commented at 9:30 pm on March 23, 2011: memberSorry for all the pull request mess the last three times. In any case, this works on all three platforms and includes WXUI switch for UPnP enabling/disabling on the fly. See http://www.bitcoin.org/smf/index.php?topic=4392.msg64230#msg64230 for discussion.
-
jgarzik commented at 9:00 pm on March 29, 2011: contributor
Comments:
-
The community poll and I seem to agree, upnp should be disabled by default (USE_UPNP==0)
-
Rather than all those ifdefs, it would be nice to define ‘static const fHaveUPNP’ and test that where possible. The compiler will optimize out code that is known never to be called.
-
-
Allow UPnP mapping when USE_UPNP is defined and miniupnpc is installed at build time(statically linked).
Thanks joepie91 for the translation of the new copyright notices into Dutch. Thanks sipa for the translation of the new copyright notices into French. Thanks megu for the translation of the new copyright notices into Spanish. Thanks justmoon/Blitzboom for the translation of the new copyright notices into German. Thanks Joozero for the translation of the new copyright notices into Italian. Remaining translations were provided by Google Translate.
-
TheBlueMatt commented at 6:48 pm on March 30, 2011: memberAlthough I disagree, UPnP is now set to off by default in all makefiles.
fHaveUPnP is used in many places now, however #ifdef USE_UPNP was still used in several. -
gavinandresen merged this on Apr 12, 2011
-
gavinandresen closed this on Apr 12, 2011
-
glv2 referenced this in commit 3f8551c828 on Nov 4, 2014
-
sipa referenced this in commit a064934ec0 on Dec 4, 2014
-
sipa referenced this in commit 87bddb7a3a on Dec 4, 2014
-
sipa referenced this in commit eb6347679b on Dec 5, 2014
-
dexX7 referenced this in commit 9e6d5ee646 on Jul 15, 2015
-
rebroad referenced this in commit dbdb6b882a on Mar 16, 2016
-
rebroad referenced this in commit fe4d759ab8 on Dec 7, 2016
-
deadalnix referenced this in commit 0bf70a5d6c on Jan 19, 2017
-
jgarzik referenced this in commit e8586e317a on Oct 12, 2017
-
destenson referenced this in commit 8d4f7a3b96 on Nov 18, 2017
-
lateminer referenced this in commit c9c47767d4 on Dec 9, 2017
-
cryptapus referenced this in commit d3a3701b3b on Jan 31, 2019
-
lateminer referenced this in commit c72fc10e12 on Feb 23, 2019
-
DrahtBot locked this on Sep 8, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 12:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 12:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me