qa: Fix wallet_listreceivedby race #13304

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1805-qaWalletRace changing 1 files +8 −4

MarcoFalke commented at 8:56 PM on May 22, 2018: member

Generating a block on node 0 will only get node 0 out of IBD and not node 1. So the inv for the txid is dropped by node 1 and the call to sync_all fails.

Solve it by a call to sync_blocks after generate.
MarcoFalke added the label Tests on May 22, 2018
MarcoFalke commented at 8:57 PM on May 22, 2018: member

One of the travis failures for reference: https://travis-ci.org/bitcoin/bitcoin/jobs/377321319
MarcoFalke force-pushed on May 22, 2018
Empact commented at 10:37 PM on May 22, 2018: member

utACK faf20a7

in test/functional/wallet_listreceivedby.py:24 in faf20a74b3 outdated

  20 | @@ -18,8 +21,7 @@ def set_test_params(self):
  21 |      def run_test(self):
  22 |          # Generate block to get out of IBD
  23 |          self.nodes[0].generate(1)
  24 | -
  25 | -        self.log.info("listreceivedbyaddress Test")
  26 | +        sync_blocks(self.nodes)

jnewbery commented at 1:44 PM on May 23, 2018:

You can use self.sync_all() here to avoid the additional import.

in test/functional/wallet_listreceivedby.py:22 in faf20a74b3 outdated
```
  20 | @@ -18,8 +21,7 @@ def set_test_params(self):
  21 |      def run_test(self):
  22 |          # Generate block to get out of IBD
  23 |          self.nodes[0].generate(1)
  24 | -
  25 | -        self.log.info("listreceivedbyaddress Test")
```
jnewbery commented at 1:46 PM on May 23, 2018:

No need to remove this. It looks like this log indicates that this part of the test is for listreceivedbyaddress compared with the next parts of the test for getreceivedbyaddress and listreceivedbylabel/getreceivedbylabel.

MarcoFalke commented at 1:53 PM on May 23, 2018:

Thanks. Removing the log statement was incorrect. Fixed up...
jnewbery commented at 1:46 PM on May 23, 2018: member

Concept ACK
qa: Fix wallet_listreceivedby race fa865efa4a
MarcoFalke force-pushed on May 23, 2018
jnewbery commented at 3:14 PM on May 23, 2018: member

Tested ACK fa865efa4a21ae08be8b4c390b7661182e0b415b
MarcoFalke merged this on May 24, 2018
MarcoFalke closed this on May 24, 2018
MarcoFalke referenced this in commit 610f4dd719 on May 24, 2018
MarcoFalke deleted the branch on May 24, 2018
MarcoFalke referenced this in commit 2c4c5febb6 on May 24, 2018
MarcoFalke referenced this in commit e1dc7ae7fa on May 24, 2018
MarcoFalke referenced this in commit d93d59a237 on May 29, 2018
MarcoFalke referenced this in commit cbdabef35e on Jul 12, 2018
jasonbcox referenced this in commit af3079ad32 on Oct 11, 2019
PastaPastaPasta referenced this in commit c42420c3ae on Apr 12, 2020
PastaPastaPasta referenced this in commit 29a0865df3 on Apr 16, 2020
ckti referenced this in commit e9948996e3 on Mar 28, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels