OpenBSD 6.3 build: test/arith_uint256_tests.cpp complains about missing argument #13337

1. 
   grim-trigger commented at 1:18 PM on May 28, 2018: contributor

   <!-- This issue tracker is only for technical issues related to Bitcoin Core. <!-- Describe the issue -->

   When running gmake check, test/arith_uint256_tests.cpp complains about missing argument.

   <!--- What behavior did you expect? -->

   Expected successful gmake check results.

   <!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->

   Output from bitcoin/src/test/arith_uint256_tests.cpp.log:

   Missing an argument value for the parameter run_test in the argument 
   
   Parameter: run_test
    Filters, which test units to include or exclude from test module execution.
    Command line formats:
      --run_test=<test unit filter>
      -t <test unit filter>
    Environment variable: BOOST_TEST_RUN_FILTERS
   
   For detailed help on Boost.Test parameters use:
     test_bitcoin --help
   or
     test_bitcoin --help=<parameter name>
   

   <!--- How reliably can you reproduce the issue, what are the steps to do so? -->

   This issue occurs when running gmake check.

   <!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->

   This issue occurs with bitcoin master version 610f4dd7

   <!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->

   This issue occurs with OpenBSD 6.3 AMD64. File config.log attached.

   <!-- Any extra information that might be useful in the debugging process. -->

   <!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

2. fanquake added the label Linux/Unix on May 28, 2018
3. 
   MarcoFalke commented at 6:33 PM on May 29, 2018: member

   We use the following command to determine the list of tests: grep "BOOST_FIXTURE_TEST_SUITE(\|BOOST_AUTO_TEST_SUITE(" | cut -d '(' -f 2 | cut -d ',' -f 1 | cut -d ')' -f 1

   You can run from the project root with: git grep "BOOST_FIXTURE_TEST_SUITE(\|BOOST_AUTO_TEST_SUITE(" src/test src/wallet/test/ | cut -d '(' -f 2 | cut -d ',' -f 1 | cut -d ')' -f 1

   Feel free to determine the cause of this issue and submit a fix as a pull request.

4. 
   laanwj commented at 6:29 PM on May 30, 2018: member

   Current 0.16 branch and master pass gmake check on OpenBSD 5.2, here. So interestingly, this looks like a 5.3 specific problem? Or does this depend on the default shell? (/bin/ksh in my case)

5. laanwj added this to the milestone 0.17.0 on May 30, 2018
6. 
   practicalswift commented at 7:50 AM on May 31, 2018: contributor

   I'm able to reproduce this issue under stock OpenBSD 6.3 using the default shell:

   $ uname -r
   6.3
   $ echo $0
   -ksh
   $ gmake check
   Making check in src
   gmake[1]: Entering directory '/.../bitcoin/src'
   gmake[2]: Entering directory '/.../bitcoin/src'
   gmake[3]: Entering directory '/.../bitcoin'
   gmake[3]: Leaving directory '/.../bitcoin'
   gmake  check-TESTS check-local
   gmake[3]: Entering directory '/.../bitcoin/src'
   gmake[4]: Entering directory '/.../bitcoin/src'
   ============================================================================
   Testsuite summary for Bitcoin Core 0.16.99
   ============================================================================
   # TOTAL: 0
   # PASS:  0
   # SKIP:  0
   # XFAIL: 0
   # FAIL:  0
   # XPASS: 0
   # ERROR: 0
   ============================================================================
   gmake[4]: Leaving directory '/.../bitcoin/src'
   Running tests: from test/arith_uint256_tests.cpp
   Missing an argument value for the parameter run_test in the argument
   
   Parameter: run_test
    Filters, which test units to include or exclude from test module execution.
    Command line formats:
      --run_test=<test unit filter>
      -t <test unit filter>
    Environment variable: BOOST_TEST_RUN_FILTERS
   
   For detailed help on Boost.Test parameters use:
     test_bitcoin --help
   or
     test_bitcoin --help=<parameter name>
   gmake[3]: *** [Makefile:10247: test/arith_uint256_tests.cpp.test] Error 1
   gmake[3]: Leaving directory '/.../bitcoin/src'
   gmake[2]: *** [Makefile:9996: check-am] Error 2
   gmake[2]: Leaving directory '/.../bitcoin/src'
   gmake[1]: *** [Makefile:9684: check-recursive] Error 1
   gmake[1]: Leaving directory '/.../bitcoin/src'
   gmake: *** [Makefile:754: check-recursive] Error 1
   

7. 
   practicalswift commented at 8:19 AM on May 31, 2018: contributor

   GNU grep and BSD grep differs in their handling of regexps when extended regular expressions are not enabled via the -E flag:

   $ grep --version | head -1
   grep (GNU grep) 3.1
   $ echo "BOOST_FIXTURE_TEST_SUITE(foo)" | grep "BOOST_FIXTURE_TEST_SUITE(\|BOOST_AUTO_TEST_SUITE("
   BOOST_FIXTURE_TEST_SUITE(foo)
   $
   

   $ grep --version | head -1
   grep version 0.9
   $ echo "BOOST_FIXTURE_TEST_SUITE(foo)" | grep "BOOST_FIXTURE_TEST_SUITE(\|BOOST_AUTO_TEST_SUITE("
   $ 
   

   The portable way to do it is:

   $ echo "BOOST_FIXTURE_TEST_SUITE(foo)" | grep -E "(BOOST_FIXTURE_TEST_SUITE\\(|BOOST_AUTO_TEST_SUITE\\()"
   BOOST_FIXTURE_TEST_SUITE(foo)
   $
   

   I'll submit a fix!

8. 
   practicalswift commented at 8:32 AM on May 31, 2018: contributor

   Fix submitted in #13355.

9. 
   grim-trigger commented at 12:19 AM on June 1, 2018: contributor

   I can confirm that #13355 resolves this issue. Thank you!

10. laanwj closed this on Jun 1, 2018

    ---

11. laanwj referenced this in commit 0b1c0c462e on Jun 1, 2018
12. UdjinM6 referenced this in commit e3b4051be8 on Jun 19, 2021
13. UdjinM6 referenced this in commit 39959fc7ef on Jun 24, 2021
14. UdjinM6 referenced this in commit 168ad2644e on Jun 26, 2021
15. UdjinM6 referenced this in commit f76c320a26 on Jun 26, 2021
16. PastaPastaPasta referenced this in commit 0072ea2988 on Jun 27, 2021
17. PastaPastaPasta referenced this in commit f8a7e1bd24 on Jun 28, 2021
18. PastaPastaPasta referenced this in commit e4aa0e6200 on Jun 28, 2021
19. UdjinM6 referenced this in commit dbb0c39f93 on Jun 28, 2021
20. PastaPastaPasta referenced this in commit 05c1b67d25 on Jun 29, 2021
21. DrahtBot locked this on Sep 8, 2021

Milestone
0.17.0