Stop translating command line options #13341

1. 
   laanwj commented at 4:54 pm on May 29, 2018: member

   Many options are extremely technical, and refer internals, making it difficult to translate usefully. This came up in discussion of e.g. #10949. If a message is not understood by translators (which are typically end-users, not developers) they’ll either translate it literally, making it harder to understand instead of easier, with the added drawback of the user no longer being able to google it.

   Also the translation was only working for bitcoin-qt as with the console programs, there is no translation backend. So it was injecting never-used translation messages for bitcoin-cli, -tx.

   For these reasons, stop translating options help completely. This should not affect the output in any way * except for bitcoin-qt when a non-English language is configured in the locale.

   This implements #10962.

   *) I checked this, but please do verify this.

2. laanwj added the label GUI on May 29, 2018
3. laanwj added the label Utils/log/libs on May 29, 2018
4. 
   ken2812221 commented at 5:20 pm on May 29, 2018: contributor

   Concept ACK. But I think we should reduce abbreviations like RBF or TX in help messages. It might be hard to understand by non-native speakers.
5. 
   laanwj commented at 5:21 pm on May 29, 2018: member

   Concept ACK. But I think we should reduce abbreviations like RBF or TX in help messages. It might be hard to understand by non-native speakers.

   Fine with me, but that’s very much out of scope here. This simply makes the change suggested in the PR and issue, nothing more.

6. 
   ken2812221 commented at 5:31 pm on May 29, 2018: contributor

   How about also get rid of translations of HelpMessageGroup in util.cpp?
7. 
   promag commented at 5:32 pm on May 29, 2018: member

   Concept ACK. Needs release notes?
8. 
   laanwj commented at 5:38 pm on May 29, 2018: member

   How about also get rid of translations of HelpMessageGroup in util.cpp?

   Done, good catch.

   Concept ACK. Needs release notes?

   I don’t think that’s necessary to mention explicitly. This is hardly even noticeable to the user.

9. 
   MarcoFalke commented at 6:14 pm on May 29, 2018: member

   utACK 2047cde5fe3aaa9cd8318a8d47e8080880a2757b (also verified that the manpages don’t change)

   Please squash.

10. 
    sipa commented at 7:19 pm on May 29, 2018: member

    Concept ACK
11. 
    achow101 commented at 8:22 pm on May 29, 2018: member

    utACK 2047cde5fe3aaa9cd8318a8d47e8080880a2757b
12. 
    practicalswift commented at 9:59 pm on May 29, 2018: contributor

    Concept ACK
13. 
    jonasschnelli commented at 8:08 am on May 30, 2018: contributor

    Thanks. Finally! utACK 2047cde5fe3aaa9cd8318a8d47e8080880a2757b (please squash).
14. Stop translating command line options

    Many options are extremely technical, and refer internals, making it
    difficult to translate usefully. This came up in discussion of e.g.
     #10949. If a message is not understood by translators (which are
    typically end-users, not developers) they'll either translate it
    literally, making it harder to understand instead of easier, with the
    added drawback of the user no longer being able to google it.
    
    Also the translation was only working for bitcoin-qt as with
    the console programs, there is no translation backend. So it was
    injecting never-used translation messages for bitcoin-cli, -tx.
    
    For these reasons, stop translating options help completely. This should
    not affect the output **in any way** except for bitcoin-qt when a
    non-English language is configured in the locale.
    
    This implements #10962.

    3d4fa83587
15. laanwj force-pushed on May 30, 2018
16. 
    laanwj commented at 12:25 pm on May 30, 2018: member

    Squashed 2047cde5fe3aaa9cd8318a8d47e8080880a2757b → 3d4fa83587759095b7f0ccfe4075808098d4ae7f

    (also verified that the manpages don’t change)

    Good idea.

17. 
    promag commented at 12:31 pm on May 30, 2018: member

    Will test.
18. 
    MarcoFalke commented at 12:47 pm on May 30, 2018: member

    re-ACK 3d4fa83587759095b7f0ccfe4075808098d4ae7f (No changes, so didn’t re-test)
19. 
    ken2812221 commented at 12:50 pm on May 30, 2018: contributor

    Tested ACK 3d4fa83587759095b7f0ccfe4075808098d4ae7f
20. MarcoFalke merged this on May 30, 2018
21. MarcoFalke closed this on May 30, 2018

    ---

22. MarcoFalke referenced this in commit 25d2df2aa9 on May 30, 2018
23. 
    promag commented at 1:46 pm on May 30, 2018: member

    Tested ACK 3d4fa83. Help -> Command line options window also show not translated.
24. laanwj referenced this in commit 1756cb4472 on Jul 4, 2018
25. PastaPastaPasta referenced this in commit 8fd40cfda9 on Jul 7, 2020
26. PastaPastaPasta referenced this in commit 8afc2f2618 on Jul 7, 2020
27. PastaPastaPasta referenced this in commit 32fdc73503 on Jul 8, 2020
28. UdjinM6 referenced this in commit 4d9644bbff on Mar 19, 2021
29. UdjinM6 referenced this in commit d78bf474af on Mar 19, 2021
30. UdjinM6 referenced this in commit b27554ba3f on Mar 19, 2021
31. random-zebra referenced this in commit e988d40e1f on Sep 6, 2021
32. MarcoFalke locked this on Sep 8, 2021

Contributors
laanwj ken2812221 promag MarcoFalke sipa achow101 practicalswift jonasschnelli

Labels
GUI Utils/log/libs