Stop translating command line options #13341

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2018_05_notranslate_options changing 10 files +206 −207
  1. laanwj commented at 4:54 PM on May 29, 2018: member

    Many options are extremely technical, and refer internals, making it difficult to translate usefully. This came up in discussion of e.g. #10949. If a message is not understood by translators (which are typically end-users, not developers) they'll either translate it literally, making it harder to understand instead of easier, with the added drawback of the user no longer being able to google it.

    Also the translation was only working for bitcoin-qt as with the console programs, there is no translation backend. So it was injecting never-used translation messages for bitcoin-cli, -tx.

    For these reasons, stop translating options help completely. This should not affect the output in any way * except for bitcoin-qt when a non-English language is configured in the locale.

    This implements #10962.

    *) I checked this, but please do verify this.

  2. laanwj added the label GUI on May 29, 2018
  3. laanwj added the label Utils/log/libs on May 29, 2018
  4. laanwj cross-referenced this on May 29, 2018 from issue Stop translating command-line option help? by laanwj
  5. ken2812221 commented at 5:20 PM on May 29, 2018: contributor

    Concept ACK. But I think we should reduce abbreviations like RBF or TX in help messages. It might be hard to understand by non-native speakers.

  6. laanwj commented at 5:21 PM on May 29, 2018: member

    Concept ACK. But I think we should reduce abbreviations like RBF or TX in help messages. It might be hard to understand by non-native speakers.

    Fine with me, but that's very much out of scope here. This simply makes the change suggested in the PR and issue, nothing more.

  7. ken2812221 commented at 5:31 PM on May 29, 2018: contributor

    How about also get rid of translations of HelpMessageGroup in util.cpp?

  8. promag commented at 5:32 PM on May 29, 2018: member

    Concept ACK. Needs release notes?

  9. promag cross-referenced this on May 29, 2018 from issue [Qt] Re-setup args after translator setup to translate help text by achow101
  10. laanwj commented at 5:38 PM on May 29, 2018: member

    How about also get rid of translations of HelpMessageGroup in util.cpp?

    Done, good catch.

    Concept ACK. Needs release notes?

    I don't think that's necessary to mention explicitly. This is hardly even noticeable to the user.

  11. MarcoFalke commented at 6:14 PM on May 29, 2018: member

    utACK 2047cde5fe3aaa9cd8318a8d47e8080880a2757b (also verified that the manpages don't change)

    Please squash.

  12. sipa commented at 7:19 PM on May 29, 2018: member

    Concept ACK

  13. achow101 commented at 8:22 PM on May 29, 2018: member

    utACK 2047cde5fe3aaa9cd8318a8d47e8080880a2757b

  14. practicalswift commented at 9:59 PM on May 29, 2018: contributor

    Concept ACK

  15. jonasschnelli commented at 8:08 AM on May 30, 2018: contributor

    Thanks. Finally! utACK 2047cde5fe3aaa9cd8318a8d47e8080880a2757b (please squash).

  16. Stop translating command line options
    Many options are extremely technical, and refer internals, making it
difficult to translate usefully. This came up in discussion of e.g.
 #10949. If a message is not understood by translators (which are
typically end-users, not developers) they'll either translate it
literally, making it harder to understand instead of easier, with the
added drawback of the user no longer being able to google it.

Also the translation was only working for bitcoin-qt as with
the console programs, there is no translation backend. So it was
injecting never-used translation messages for bitcoin-cli, -tx.

For these reasons, stop translating options help completely. This should
not affect the output **in any way** except for bitcoin-qt when a
non-English language is configured in the locale.

This implements #10962.
    3d4fa83587
  17. laanwj force-pushed on May 30, 2018
  18. laanwj commented at 12:25 PM on May 30, 2018: member

    Squashed 2047cde5fe3aaa9cd8318a8d47e8080880a2757b → 3d4fa83587759095b7f0ccfe4075808098d4ae7f

    (also verified that the manpages don't change)

    Good idea.

  19. promag commented at 12:31 PM on May 30, 2018: member

    Will test.

  20. MarcoFalke commented at 12:47 PM on May 30, 2018: member

    re-ACK 3d4fa83587759095b7f0ccfe4075808098d4ae7f (No changes, so didn't re-test)

  21. ken2812221 commented at 12:50 PM on May 30, 2018: contributor

    Tested ACK 3d4fa83587759095b7f0ccfe4075808098d4ae7f

  22. MarcoFalke merged this on May 30, 2018
  23. MarcoFalke closed this on May 30, 2018
  24. MarcoFalke referenced this in commit 25d2df2aa9 on May 30, 2018
  25. promag commented at 1:46 PM on May 30, 2018: member

    Tested ACK 3d4fa83. Help -> Command line options window also show not translated.

  26. laanwj cross-referenced this on May 30, 2018 from issue Throw an error for unknown args by achow101
  27. MarcoFalke cross-referenced this on May 30, 2018 from issue wallet: Replace %w by wallet name in -walletnotify script by promag
  28. MarcoFalke cross-referenced this on May 30, 2018 from issue Don't edit Chainparams after initialization by jtimon
  29. MarcoFalke cross-referenced this on May 30, 2018 from issue Thread names in logs and deadlock debug tools (take 2) by jamesob
  30. MarcoFalke cross-referenced this on May 30, 2018 from issue Interpret absense of prune= as prune=1 if there are pruned blocks by Sjors
  31. MarcoFalke cross-referenced this on May 30, 2018 from issue Store the current config file at read time, and return it from GetConfigFile if set by Empact
  32. Bushstar cross-referenced this on Jun 1, 2018 from issue commits from bitcoin/master by Bushstar
  33. ken2812221 cross-referenced this on Jul 4, 2018 from issue Docs: Modify policy to not translate command-line help by ken2812221
  34. laanwj referenced this in commit 1756cb4472 on Jul 4, 2018
  35. ryanofsky cross-referenced this on Jan 7, 2019 from issue Add fee_est tool for debugging fee estimation code by ryanofsky
  36. PastaPastaPasta referenced this in commit 8fd40cfda9 on Jul 7, 2020
  37. PastaPastaPasta referenced this in commit 8afc2f2618 on Jul 7, 2020
  38. PastaPastaPasta referenced this in commit 32fdc73503 on Jul 8, 2020
  39. UdjinM6 referenced this in commit 4d9644bbff on Mar 19, 2021
  40. UdjinM6 referenced this in commit d78bf474af on Mar 19, 2021
  41. UdjinM6 referenced this in commit b27554ba3f on Mar 19, 2021
  42. Fuzzbawls cross-referenced this on Aug 1, 2021 from issue [GUI] Translation cleanup by Fuzzbawls
  43. random-zebra referenced this in commit e988d40e1f on Sep 6, 2021
  44. bitcoin locked this on Sep 8, 2021
Contributors
laanwjken2812221promagMarcoFalkesipaachow101practicalswiftjonasschnelli
Labels
GUIUtils/log/libs
Linked (view graph)
#10443 Add fee_est tool for debugging fee estimation code#10949 Clarify help message for -discardfee#10962 Stop translating command-line option help?#12765 Store the current config file at read time, and return it from GetConfigFile if set#13029 Interpret absense of prune= as prune=1 if there are pruned blocks#13112 Throw an error for unknown args#13168 Thread names in logs and deadlock debug tools (take 2)#13289 [Qt] Re-setup args after translator setup to translate help text#13311 Don't edit Chainparams after initialization#13339 wallet: Replace %w by wallet name in -walletnotify script#13592 Docs: Modify policy to not translate command-line help
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 08:54 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me