Update gitian-build.sh for docker #13368

1. 
   achow101 commented at 6:08 PM on June 1, 2018: member

   Updates gitian-build.sh script for the docker virtualization method recently added to gitian-builder.

   Second commit depends on https://github.com/devrandom/gitian-builder/pull/185

2. Add option to use docker for gitian-build.sh 86967b2e35
3. fanquake added the label Build system on Jun 2, 2018
4. fanquake requested review from theuni on Jun 2, 2018
5. 
   laanwj commented at 1:46 PM on June 5, 2018: member

   Concept ACK, thanks for working on this.

6. in contrib/gitian-build.sh:262 in 4b5b2c9c39 outdated

    255 | @@ -238,6 +256,10 @@ then
    256 |      then
    257 |          sudo apt-get install lxc
    258 |          bin/make-base-vm --suite trusty --arch amd64 --lxc
    259 | +    elif [[ -n "$USE_DOCKER" ]]
    260 | +    then
    261 | +        sudo apt-get install docker-ce
    262 | +        bin/make-base-vm --suite trusty --arch amd64 --docker --docker-image-digest b8855dc848e2622653ab557d1ce2f4c34218a9380cceaa51ced85c5f3c8eb201
   

   ---

   ---

   

   ken2812221 commented at 3:04 PM on June 5, 2018:

   Are you sure that this digest will stay the same? They update the image very often. https://hub.docker.com/r/library/ubuntu/tags/

   Edit: That make sure that docker always pull the same image base.

   ---

   

   MarcoFalke commented at 10:26 PM on June 17, 2018:

   Is there any way to verify this hash?

   I tried to build the image from scratch using https://github.com/tianon/docker-brew-ubuntu-core/blob/master/update.sh but it would give a different hash each run...

   ---

   

   MarcoFalke commented at 3:33 PM on June 22, 2018:

   @achow101 Is this hash even supposed to be deterministic or does it just serve the purpose of an unique identifier?

   ---

   

   achow101 commented at 2:48 AM on June 23, 2018:

   I'm not sure.. I think it may just serve as a unique identifier.

   ---

   

   MarcoFalke commented at 8:23 PM on July 14, 2018:

   In that case I'd prefer the second commit to be dropped. I believe for our purposes it suffices to use the "ubuntu:bionic" as a unique identifier.

7. 
   MarcoFalke commented at 10:27 PM on June 17, 2018: member

   utACK 86967b2e35d500bb4a5053c44aed809775a3e04e

8. 
   ken2812221 commented at 7:23 AM on June 21, 2018: contributor

   Tested ACK 4b5b2c9c398237645450e25fe7188a3e0422e94a

9. 
   fanquake commented at 1:35 PM on July 15, 2018: member

   Concept ACK, should this go in before #13623?

10. achow101 force-pushed on Jul 15, 2018
11. 
    achow101 commented at 8:18 PM on July 15, 2018: member

    I dropped the second commit that used gitian image hashes.

12. MarcoFalke merged this on Jul 15, 2018
13. MarcoFalke closed this on Jul 15, 2018

    ---

14. MarcoFalke referenced this in commit c0f1569557 on Jul 15, 2018
15. 
    ken2812221 commented at 4:46 AM on July 16, 2018: contributor

    Do this actually work with latest version of gitian-builder? I always get a error message Error: No such container: gitian-target

16. 
    achow101 commented at 5:16 AM on July 16, 2018: member

    @ken2812221 It works for me. Maybe you need to run it as root (with sudo) or set docker to run without root.

17. DrahtBot locked this on Sep 8, 2021

Contributors

achow101laanwjken2812221MarcoFalkefanquake

Review Requested
theuni