Qt: Update Wallet Encryption Titles To Better Describe Process #13373

pull eudisd wants to merge 1 commits into bitcoin:master from eudisd:feature/bitcoin-#13245 changing 3 files +10 −10

eudisd commented at 5:10 PM on June 2, 2018: none
Summary

Refs #13245

Hey guys, trying to get my feet wet with contributing. I've identified this issue as an easy first step.

I've focused on the GUI/copy part initially.

Couple of things to note:
- Ran both automation/integration and unit tests for this.
- I intentionally left out the translations per the contributing guidelines.
Let me know of any additional changes/fixes you'd like to see.

Screenshots

Refs #13245

Updating wallet encryption dialog titles to better describe wallet encryption

88a7967c0e

fanquake added the label GUI on Jun 3, 2018

in src/qt/askpassphrasedialog.cpp:115 in 88a7967c0e

 110 | @@ -111,8 +111,8 @@ void AskPassphraseDialog::accept()
 111 |              // Cannot encrypt with empty passphrase
 112 |              break;
 113 |          }
 114 | -        QMessageBox::StandardButton retval = QMessageBox::question(this, tr("Confirm wallet encryption"),
 115 | -                 tr("Warning: If you encrypt your wallet and lose your passphrase, you will <b>LOSE ALL OF YOUR BITCOINS</b>!") + "<br><br>" + tr("Are you sure you wish to encrypt your wallet?"),
 116 | +        QMessageBox::StandardButton retval = QMessageBox::question(this, tr("Confirm create encrypted wallet"),
 117 | +                 tr("Warning: If you encrypt your wallet and lose your passphrase, you will <b>LOSE ALL OF YOUR BITCOINS</b>!") + "<br><br>" + tr("Are you sure you want to create a new encrypted wallet?"),

marcoagner commented at 11:21 AM on June 4, 2018:

Could be cool to seize the opportunity to remove the <b> tag from tr() call. See this or this for some examples. (unless somebody knows of a good reason style tags should be kept for translators but I don't think that's the case)

eudisd closed this on Jun 6, 2018
eudisd commented at 4:01 PM on June 6, 2018: none

Closing as there is still discussions as to how to proceeed
MarcoFalke locked this on Sep 8, 2021

Contributors

eudisd

marcoagner

Labels

GUI

Linked (view graph)

#13245 Misleading "Encrypt wallet" GUI process

Qt: Update Wallet Encryption Titles To Better Describe Process #13373

Summary

Screenshots