[GUI]: Missing line breaks for Notifications #13376

globaltoken commented at 11:18 AM on June 3, 2018: none

Hey,

While testing in regtest I noticed a small issue. I used the current Master branch and entered regtest, and generated blocks.

While receiving regtest rewards I noticed that the GUI Notification for receiving is missing line breaks. A Screenshot has been attached.

Regards, Pawel issue

fanquake added the label GUI on Jun 3, 2018

qmma70 commented at 3:49 AM on June 5, 2018: contributor

Just tried this out -- works fine on macOS. I suspect this is working on Unix/Linux as well.

A quick look at the file below shows we're already doing things correctly (i.e. using \n for plaintext message in QSystemTrayIcon::showMessage). https://github.com/bitcoin/bitcoin/blob/a315b79ad2b8f76b66f8c2b79bbe5da43cca8b4a/src/qt/bitcoingui.cpp#L1026

As a work around, maybe we can use some separator like , or . on Windows instead of relying on the OS's interpretation of \n?

globaltoken commented at 5:16 AM on June 5, 2018: none

@qmma70 I used the current master branch, not 0.16, I compiled a Wallet by myself, because I tried --enable-debug. Earlier versions are not affected by this issue, it seems to be buggy after 0.16 (current Master branch.)

Regards

qmma70 commented at 12:07 AM on June 6, 2018: contributor

I understand -- I was running from my build as well.

I noticed the code hasn't changed in a while now, so this looks more like an environmental issue.

fanquake commented at 8:58 AM on June 13, 2018: member

@globaltoken If this was self compiled, what version of Qt was used?

globaltoken commented at 8:44 PM on June 13, 2018: none

@fanquake I used QT 5.7.1

fanquake commented at 12:16 PM on February 4, 2020: member

I can't recreate this issue on Windows using the latest release binaries.

notification_popup

notification_bar

fanquake closed this on Feb 4, 2020

DrahtBot locked this on Feb 15, 2022