cli: Ignore libevent warnings #13394

pull theuni wants to merge 1 commits into bitcoin:master from theuni:cli-event changing 1 files +13 −0

theuni commented at 7:00 PM on June 4, 2018: member

Should fix rpc tests that fail due to an unclean stderr.

Untested as I'm not seeing these warnings. @promag mind seeing if this fixes your problem?
cli: Ignore libevent warnings 0231ef6c6d
laanwj added the label RPC/REST/ZMQ on Jun 4, 2018
laanwj commented at 12:20 AM on June 5, 2018: member

utACK 0231ef6c6d4f45edffda4ac3bce2048f9c8a8c00
Empact commented at 8:54 AM on June 5, 2018: member

According to the below the default is to log message to stderr, do we want to keep logging the lower-level messages? http://www.wangafu.net/~nickm/libevent-book/Ref1_libsetup.html

Edit: here's the current default behavior https://github.com/libevent/libevent/blob/e83443ec67d45447296c2ce320620a07c88e1d32/log.c#L223
laanwj commented at 5:18 PM on June 5, 2018: member

Yes, the messages go to stderr. Which is normally fine, at least they don't mess up the application output! But the extra stderr output (something with a certain version of OSX) was causing problems in the functional tests for @promag.
Empact commented at 7:47 PM on June 5, 2018: member

Maybe send them to the debuglogfile?
laanwj commented at 5:40 AM on June 7, 2018: member
No, bitcoin-cli should definitely not write to any debug log file.
- That'd be entirely unexpected for a simple command line tool
- It gets in the way of concurrent usage
laanwj commented at 5:41 AM on June 7, 2018: member

@promag Can you test this? It's kind of blocked on that.

promag commented at 6:48 AM on June 7, 2018: member

Tested ACK 0231ef6 - it fixes my problem. @theuni how could I test the throw added?

Before:

./src/bitcoin-cli -regtest help
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0
== Blockchain ==
getbestblockhash
...

After

./src/bitcoin-cli -regtest help
== Blockchain ==
getbestblockhash
...

laanwj merged this on Jun 7, 2018
laanwj closed this on Jun 7, 2018
laanwj referenced this in commit e1f8dce993 on Jun 7, 2018
MarcoFalke commented at 2:17 PM on June 7, 2018: member

@theuni how could I test the throw added? @promag You can test the throw by replacing severity >= EVENT_LOG_ERR with true. Would you mind doing that post-merge, please?
jasonbcox referenced this in commit 50ae4433e7 on Oct 11, 2019
jonspock referenced this in commit 01284e855d on Dec 27, 2019
jonspock referenced this in commit 4340f5ce59 on Dec 29, 2019
UdjinM6 referenced this in commit c93ea07505 on Jun 19, 2021
UdjinM6 referenced this in commit 4091989d36 on Jun 24, 2021
UdjinM6 referenced this in commit 2942aa5a46 on Jun 26, 2021
UdjinM6 referenced this in commit d4b4779eae on Jun 26, 2021
PastaPastaPasta referenced this in commit 7c84a2149b on Jun 27, 2021
PastaPastaPasta referenced this in commit 82083964a4 on Jun 28, 2021
PastaPastaPasta referenced this in commit c7dc658859 on Jun 28, 2021
UdjinM6 referenced this in commit 62c1477638 on Jun 28, 2021
PastaPastaPasta referenced this in commit d6fac3bd4f on Jun 29, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels