[tests] speed up of tx_validationcache_tests by reusing of CTransaction. #13404

pull lucash-dev wants to merge 1 commits into bitcoin:master from lucash-dev:speedup-tx_validationcache_tests changing 1 files +1 −1

lucash-dev commented at 5:36 AM on June 6, 2018: contributor
The code was converting CMutableTransaction to CTransaction multiple times, which implies recalculating the hash multiple times. This commit fixes this by reusing a single CTransaction.

Run-time results:
```
Before:  6.7s
After: 5.5s
--------------
Saved: 1.2s
```
This PR was split from #13050. Also, see #10026.
fanquake added the label Tests on Jun 6, 2018

in src/test/txvalidationcache_tests.cpp:105 in ba4311a515 outdated

 101 | @@ -102,7 +102,7 @@ BOOST_FIXTURE_TEST_CASE(tx_mempool_block_doublespend, TestChain100Setup)
 102 |  // should fail.
 103 |  // Capture this interaction with the upgraded_nop argument: set it when evaluating
 104 |  // any script flag that is implemented as an upgraded NOP code.
 105 | -static void ValidateCheckInputsForAllFlags(CMutableTransaction &tx, uint32_t failing_flags, bool add_to_cache)
 106 | +static void ValidateCheckInputsForAllFlags(CTransaction tx, uint32_t failing_flags, bool add_to_cache)

Empact commented at 11:02 AM on June 6, 2018:

Could be const or a const reference.

MarcoFalke commented at 12:25 PM on June 6, 2018:

Agree that this should be a const ref

lucash-dev commented at 1:51 PM on June 6, 2018:

Fixed.

speed up of tx_validationcache_tests by reusing of CTransaction.

The code was converting CMutableTransaction to CTransaction multiple times, which implies recalculating the hash multiple times. This commit fixes this by reusing a single CTransaction.

ebebedce20

MarcoFalke commented at 2:15 PM on June 6, 2018: member

utACK ebebedce2094ac202bdfdf4b13fed562d35d161d
MarcoFalke merged this on Jun 7, 2018
MarcoFalke closed this on Jun 7, 2018
MarcoFalke referenced this in commit 3d3d8ae3a0 on Jun 7, 2018
UdjinM6 referenced this in commit 8c8b51e5f5 on Jun 19, 2021
UdjinM6 referenced this in commit d02a223c97 on Jun 24, 2021
UdjinM6 referenced this in commit 5bb511dd46 on Jun 26, 2021
UdjinM6 referenced this in commit a13dee3fa7 on Jun 26, 2021
PastaPastaPasta referenced this in commit 02b0442fda on Jun 27, 2021
PastaPastaPasta referenced this in commit 7642625575 on Jun 28, 2021
PastaPastaPasta referenced this in commit 9c23705d84 on Jun 28, 2021
UdjinM6 referenced this in commit e52bf1371b on Jun 28, 2021
PastaPastaPasta referenced this in commit a023431fbc on Jun 29, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10026 Overview of slow unit tests #13050 [tests] improvements to slow unit tests