crypto: cleanup sha256 build #13408

pull theuni wants to merge 1 commits into bitcoin:master from theuni:sha2-cleanup changing 5 files +20 −26

theuni commented at 7:28 PM on June 6, 2018: member

Requested by @sipa in #13386.

Rather than appending all possible cpu variants to all targets, create a convenience variable that encompasses all.

crypto: cleanup sha256 build

Rather than appending all possible cpu variants to all targets, create a
convenience variable that encompasses all.

f68049dd87

in src/Makefile.am:48 in 1d86e1789c outdated
```
  42 | @@ -45,15 +43,23 @@ if ENABLE_WALLET
  43 |  LIBBITCOIN_WALLET=libbitcoin_wallet.a
  44 |  endif
  45 |  
  46 | +LIBBITCOIN_CRYPTO= $(LIBBITCOIN_CRYPTO_BASE)
  47 | +if ENABLE_SSE41
  48 | +LIBBITCOIN_CRYPTO_SSE41 = crypto/libbitcoin_crypto_sse41.a
```
Empact commented at 7:42 PM on June 6, 2018:

Given this and LIBBITCOIN_CRYPTO_AVX2 aren't referenced elsewhere, they could be inlined.

theuni commented at 9:38 PM on June 6, 2018:

Sure, but I'd prefer to stick with our convention of naming everything for easier re-use down the road.
theuni force-pushed on Jun 6, 2018
fanquake added the label Build system on Jun 7, 2018
laanwj commented at 4:54 AM on June 7, 2018: member

utACK f68049dd879c216d1e98b6635eec488f8e936ed4
DrahtBot commented at 3:19 PM on June 7, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #13386 (SHA256 implementations based on Intel SHA Extensions by sipa)
- #13203 (Add POWER8 ASM for 4-way SHA256 by TheBlueMatt)
- #12788 ([build] Tune wildcards for LIBSECP256K1 target by kallewoof)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
sipa commented at 5:23 PM on June 7, 2018: member

utACK f68049dd879c216d1e98b6635eec488f8e936ed4
laanwj merged this on Jun 11, 2018
laanwj closed this on Jun 11, 2018
laanwj referenced this in commit 70a03c635b on Jun 11, 2018
codablock referenced this in commit cd16312712 on Oct 1, 2019
codablock referenced this in commit adfd2e1a83 on Oct 1, 2019
barrystyle referenced this in commit 84d549d17b on Jan 22, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#13386 SHA256 implementations based on Intel SHA Extensions