[tests] Speed up knapsack_solver_test by not recreating wallet 100 times. #13419

1. 
   lucash-dev commented at 2:59 am on June 8, 2018: contributor

   Optimization of knapsack_solver_testby moving an expensive wallet creation to outside a 100x for loop.

   On my (slow) machine:

   0before:        9.8s
   1after:         6.2s
   2--------------------
   3saved:         3.6s (36%)
   

   This PR was split from #13050. Also see #10026.

2. fanquake added the label Tests on Jun 8, 2018
3. 
   achow101 commented at 4:09 am on June 8, 2018: member

   I don’t think this is entirely useful considering that this test will be removed (hopefully soon) altogether by #13307.
4. 
   laanwj commented at 4:05 pm on June 8, 2018: member

   I don’t think this is entirely useful considering that this test will be removed (hopefully soon) altogether by #13307.

   On the other hand this change is pretty straightforward, and might make sense until #13307 is merged.

5. 
   DrahtBot commented at 5:19 pm on June 8, 2018: member
6. 
   practicalswift commented at 8:44 pm on June 10, 2018: contributor

   Concept ACK
7. DrahtBot added the label Needs rebase on Jul 24, 2018
8. Speed up knapsack_solver_test by not recreating wallet 100 times.

   Moved the code for creating the wallet out of the 100-times repetition loop, for the most time-consuming tests.

   a679109be4
9. 
   lucash-dev commented at 1:47 am on August 11, 2018: contributor

   Rebased.
10. DrahtBot removed the label Needs rebase on Aug 11, 2018
11. 
    laanwj commented at 7:29 am on September 11, 2018: member

    It’s months later and #13307 is still in state of flux. I’m going ahead and merging this.
12. laanwj merged this on Sep 11, 2018
13. laanwj closed this on Sep 11, 2018

    ---

14. laanwj referenced this in commit e3fec3cfa8 on Sep 11, 2018
15. 
    MarcoFalke commented at 5:30 pm on September 12, 2018: member

    :tada: Congratz on halving the total memory usage of make check as well:

    https://bitcoinperf.com/timeline/?exe=3%2C4%2C2%2C1&base=1%2B23&ben=makecheck.clang.3.mem-usage&env=1&revs=10&equid=on&quarts=on&extr=on

    

16. lucash-dev deleted the branch on Sep 15, 2018
17. jasonbcox referenced this in commit 06c02066ff on Dec 20, 2019
18. jonspock referenced this in commit 87d07da2e3 on Jan 10, 2020
19. proteanx referenced this in commit 933957539a on Jan 10, 2020
20. Munkybooty referenced this in commit 5b5a76e4eb on Jul 7, 2021
21. Munkybooty referenced this in commit c2d9621ec7 on Jul 8, 2021
22. Munkybooty referenced this in commit e427d09b5e on Jul 9, 2021
23. Munkybooty referenced this in commit 3e388c6c91 on Jul 11, 2021
24. MarcoFalke locked this on Sep 8, 2021

Contributors
lucash-dev achow101 laanwj DrahtBot practicalswift MarcoFalke

Labels
Tests