Because false is synonymous with TX_NONSTANDARD, this conveys the same information and makes the handling explicitly based on script type, simplifying each call site.
Prior to this change it was common for the return value to be ignored, or for the return value and TX_NONSTANDARD to be redundantly handled.
75@@ -76,7 +76,7 @@ bool IsStandard(const CScript& scriptPubKey, txnouttype& whichType, const bool w
76 else if (!witnessEnabled && (whichType == TX_WITNESS_V0_KEYHASH || whichType == TX_WITNESS_V0_SCRIPTHASH))
77 return false;
78
79- return whichType != TX_NONSTANDARD && whichType != TX_WITNESS_UNKNOWN;
80+ return true;
foo(args, modifiedargs) stuff in general.)
164- return false;
165+ txnouttype whichType = Solver(scriptPubKey, vSolutions);
166
167- if (whichType == TX_PUBKEY)
168- {
169+ if (whichType == TX_NONSTANDARD) {
if is unnecessary as TX_NONSTANDARD will return false anyways at the end of these if blocks.
72@@ -73,7 +73,7 @@ bool IsStandard(const CScript& scriptPubKey, txnouttype& whichType)
73 (!fAcceptDatacarrier || scriptPubKey.size() > nMaxDatacarrierBytes))
{ }.
utACK bdcde81.
I wonder if TX_NONSTANDARD should have a note that it must be 0 (which is the enum default) for when if (Solver(...)) is used?
74+ (!fAcceptDatacarrier || scriptPubKey.size() > nMaxDatacarrierBytes)) {
75 return false;
76+ }
77
78- return whichType != TX_NONSTANDARD && whichType != TX_WITNESS_UNKNOWN;
79+ return true;
Because false is synonymous with TX_NONSTANDARD, this conveys the same
information and makes the handling explicitly based on script type,
simplifying each call site.
Prior to this change it was common for the return value to be ignored,
or for the return value and TX_NONSTANDARD to be redundantly handled.