The C++11 constructor of std::vector that takes an initializer list, is not explicit. Thus, the macro is not required and can be dropped.
Hopefully fixes #13456
tests: Drop variadic macro #13457
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1806-qaVariadicMacro changing 1 files +6 −9-
MarcoFalke commented at 1:54 PM on June 13, 2018: member
- MarcoFalke added the label Tests on Jun 13, 2018
-
tests: Drop variadic macro faf52f953b
- MarcoFalke force-pushed on Jun 13, 2018
-
MarcoFalke commented at 2:00 PM on June 13, 2018: member
@sipsorcery Would you mind testing, since I don't have a MSVC?
-
practicalswift commented at 2:03 PM on June 13, 2018: contributor
Concept ACK
-
sipsorcery commented at 2:24 PM on June 13, 2018: member
~utACK~ (whoops) tACK (msvc).
-
MarcoFalke commented at 2:35 PM on June 13, 2018: member
utACK (msvc).
untested (ut) or tested? A tested ack is always preferred ;)
-
sipsorcery commented at 2:40 PM on June 13, 2018: member
@MarcoFalke sorry should have been a tested ACK. Compiled the PR with msvc and successfully ran the test_bitcoin.exe.
-
laanwj commented at 3:12 PM on June 13, 2018: member
utACK faf52f953b47aac6a39892b037eaa3f08d46b655
- laanwj merged this on Jun 13, 2018
- laanwj closed this on Jun 13, 2018
- laanwj referenced this in commit b2221381e7 on Jun 13, 2018
- MarcoFalke deleted the branch on Jun 13, 2018
- deadalnix referenced this in commit edc303d7a3 on Jun 22, 2020
- ftrader referenced this in commit b75c8518e9 on Aug 17, 2020
- UdjinM6 referenced this in commit 67a485143e on Jun 20, 2021
- UdjinM6 referenced this in commit 2abcb1049e on Jun 24, 2021
- UdjinM6 referenced this in commit 26915c7ba8 on Jun 26, 2021
- UdjinM6 referenced this in commit d69958c64b on Jun 26, 2021
- UdjinM6 referenced this in commit 8f70db248e on Jun 26, 2021
- UdjinM6 referenced this in commit c1a84f6d59 on Jun 28, 2021
- MarcoFalke locked this on Sep 8, 2021
