doc: Remove note to install all boost dev packages #13460

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1806-docBuildUbuntu changing 1 files +1 −13

MarcoFalke commented at 7:14 PM on June 13, 2018: member

Those notes are for systems that are EOL. Also, those instructions would pull in a ton of additional dependencies such as python2.

Can be reviewed with git diff HEAD~ --word-diff
doc: Remove note to install all boost dev packages fa3d39ec53
MarcoFalke added the label Docs on Jun 13, 2018

in doc/build-unix.md:73 in fa3d39ec53

  81 | -        sudo apt-get install libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-program-options-dev libboost-test-dev libboost-thread-dev
  82 | -
  83 | -2. If that doesn't work, you can install all boost development packages with:
  84 | -
  85 | -        sudo apt-get install libboost-all-dev
  86 | +    sudo apt-get install build-essential libtool autotools-dev automake pkg-config libssl-dev libevent-dev bsdmainutils python3 libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-program-options-dev libboost-test-dev libboost-thread-dev

promag commented at 12:50 AM on June 14, 2018:

ultra nit sort packages.

promag commented at 12:52 AM on June 14, 2018:

why bsdmainutils?

laanwj commented at 9:41 AM on June 14, 2018:

@promag hexdump

promag commented at 12:55 AM on June 14, 2018: member

Travis failed with same error as #13461 (comment)

  CXXLD    bitcoin-cli
  CXXLD    bitcoin-tx
  CXXLD    test/test_bitcoin
  CXXLD    bench/bench_bitcoin
  OBJCXXLD qt/bitcoin-qt
/bin/mkdir -p Bitcoin-Qt.app/Contents/MacOS
STRIPPROG="/home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/share/../native/bin/x86_64-apple-darwin11-strip" /bin/bash /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-apple-darwin11/build-aux/install-sh -c -s  src/qt/bitcoin-qt Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-apple-darwin11/build-aux/install-sh: src/qt/bitcoin-qt does not exist.
Makefile:1214: recipe for target 'Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt' failed
make: *** [Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt] Error 1
make: *** Waiting for unfinished jobs....

fanquake deleted a comment on Jun 14, 2018
laanwj commented at 10:30 AM on June 14, 2018: member

utACK fa3d39ec531c52fce0acc557a9b41234b877623c
practicalswift commented at 8:35 PM on June 14, 2018: contributor

utACK fa3d39ec531c52fce0acc557a9b41234b877623c
MarcoFalke merged this on Jun 14, 2018
MarcoFalke closed this on Jun 14, 2018
MarcoFalke referenced this in commit 1939536eea on Jun 14, 2018
MarcoFalke deleted the branch on Jun 14, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#13469 Intermittent Mac CI failure